Skip to content

Commit 3c115e8

Browse files
authored
fix(ci): validate app and lib in check workflow (#22)
Co-authored-by: skulidropek <skulidropek@users.noreply.github.com>
1 parent 13629ac commit 3c115e8

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

.github/workflows/check.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ jobs:
3232
- uses: actions/checkout@v6
3333
- name: Install dependencies
3434
uses: ./.github/actions/setup
35-
- run: pnpm check
36-
- name: Types (lib)
37-
run: pnpm --filter @effect-template/lib typecheck
35+
- name: Typecheck (app)
36+
run: pnpm --filter ./packages/app check
37+
- name: Typecheck (lib)
38+
run: pnpm --filter ./packages/lib typecheck
3839

3940
lint:
4041
name: Lint
@@ -50,9 +51,10 @@ jobs:
5051
# See: https://github.com/ton-ai-core/vibecode-linter/issues (pending issue)
5152
- name: Install global linter dependencies
5253
run: npm install -g typescript @biomejs/biome
53-
- run: pnpm lint
54+
- name: Lint (app)
55+
run: pnpm --filter ./packages/app lint
5456
- name: Lint (lib)
55-
run: pnpm --filter @effect-template/lib lint
57+
run: pnpm --filter ./packages/lib lint
5658

5759
test:
5860
name: Test
@@ -65,9 +67,10 @@ jobs:
6567
# vibecode-linter uses npx internally for dependency checks (lint:tests runs first)
6668
- name: Install global linter dependencies
6769
run: npm install -g typescript @biomejs/biome
68-
- run: pnpm test
70+
- name: Test (app)
71+
run: pnpm --filter ./packages/app test
6972
- name: Test (lib)
70-
run: pnpm --filter @effect-template/lib test
73+
run: pnpm --filter ./packages/lib test
7174

7275
lint-effect:
7376
name: Lint Effect-TS
@@ -77,6 +80,7 @@ jobs:
7780
- uses: actions/checkout@v6
7881
- name: Install dependencies
7982
uses: ./.github/actions/setup
80-
- run: pnpm lint:effect
83+
- name: Lint Effect-TS (app)
84+
run: pnpm --filter ./packages/app lint:effect
8185
- name: Lint Effect-TS (lib)
82-
run: pnpm --filter @effect-template/lib lint:effect
86+
run: pnpm --filter ./packages/lib lint:effect

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@
99
],
1010
"scripts": {
1111
"build": "pnpm --filter ./packages/app build",
12-
"check": "pnpm --filter ./packages/app check",
12+
"check": "pnpm --filter ./packages/app check && pnpm --filter ./packages/lib typecheck",
1313
"changeset": "changeset",
1414
"changeset-publish": "node -e \"if (!process.env.NPM_TOKEN) { console.log('Skipping publish: NPM_TOKEN is not set'); process.exit(0); }\" && changeset publish",
1515
"changeset-version": "changeset version",
1616
"clone": "pnpm --filter ./packages/app build && node packages/app/dist/main.js clone",
1717
"docker-git": "pnpm --filter ./packages/app build:docker-git && node packages/app/dist/src/docker-git/main.js",
1818
"list": "pnpm --filter ./packages/app build && node packages/app/dist/main.js list",
1919
"dev": "pnpm --filter ./packages/app dev",
20-
"lint": "pnpm --filter ./packages/app lint",
20+
"lint": "pnpm --filter ./packages/app lint && pnpm --filter ./packages/lib lint",
2121
"lint:tests": "pnpm --filter ./packages/app lint:tests",
22-
"lint:effect": "pnpm --filter ./packages/app lint:effect",
23-
"test": "pnpm --filter ./packages/app test",
24-
"typecheck": "pnpm --filter ./packages/app typecheck",
22+
"lint:effect": "pnpm --filter ./packages/app lint:effect && pnpm --filter ./packages/lib lint:effect",
23+
"test": "pnpm --filter ./packages/app test && pnpm --filter ./packages/lib test",
24+
"typecheck": "pnpm --filter ./packages/app typecheck && pnpm --filter ./packages/lib typecheck",
2525
"start": "pnpm --filter ./packages/app start"
2626
},
2727
"devDependencies": {

0 commit comments

Comments
 (0)