Fix PHP 8.4 deprecations (#13)

Author: BafS

.github/workflows/tests.yml

@@ -16,7 +16,7 @@ jobs:
         php-version:
           - 8.0
           - 8.1
-          - 8.2
+          - 8.4
 
     steps:
       - name: Checkout code

composer.json

@@ -23,7 +23,7 @@
     }
   },
   "require": {
-    "php-64bit": ">=7.0",
+    "php-64bit": ">=7.1",
     "pleonasm/merkle-tree": "~1.0.0",
     "composer/semver": "^1.4.0|^3.2.0",
     "lastguest/murmurhash": "^v2.0.0",

src/Address/AddressCreator.php

@@ -101,7 +101,7 @@ public function fromOutputScript(ScriptInterface $outputScript): Address
      * @return Address
      * @throws UnrecognizedAddressException
      */
-    public function fromString(string $strAddress, NetworkInterface $network = null): Address
+    public function fromString(string $strAddress, ?NetworkInterface $network = null): Address
     {
         $network = $network ?: Bitcoin::getNetwork();
 

src/Address/AddressInterface.php

@@ -14,7 +14,7 @@ interface AddressInterface
      * @param NetworkInterface $network
      * @return string
      */
-    public function getAddress(NetworkInterface $network = null): string;
+    public function getAddress(?NetworkInterface $network = null): string;
 
     /**
      * @return BufferInterface

src/Address/Base58Address.php

@@ -15,7 +15,7 @@ abstract class Base58Address extends Address implements Base58AddressInterface
      * @param NetworkInterface|null $network
      * @return string
      */
-    public function getAddress(NetworkInterface $network = null): string
+    public function getAddress(?NetworkInterface $network = null): string
     {
         $network = $network ?: Bitcoin::getNetwork();
         $payload = new Buffer($this->getPrefixByte($network) . $this->getHash()->getBinary());

src/Address/Base58AddressInterface.php

@@ -12,5 +12,5 @@ interface Base58AddressInterface extends AddressInterface
      * @param NetworkInterface $network
      * @return string
      */
-    public function getPrefixByte(NetworkInterface $network = null): string;
+    public function getPrefixByte(?NetworkInterface $network = null): string;
 }

src/Address/BaseAddressCreator.php

@@ -14,7 +14,7 @@ abstract class BaseAddressCreator
      * @param NetworkInterface|null $network
      * @return Address
      */
-    abstract public function fromString(string $strAddress, NetworkInterface $network = null): Address;
+    abstract public function fromString(string $strAddress, ?NetworkInterface $network = null): Address;
 
     /**
      * @param ScriptInterface $script

src/Address/Bech32AddressInterface.php

@@ -12,5 +12,5 @@ interface Bech32AddressInterface extends AddressInterface
      * @param NetworkInterface $network
      * @return string
      */
-    public function getHRP(NetworkInterface $network = null): string;
+    public function getHRP(?NetworkInterface $network = null): string;
 }

src/Address/PayToPubKeyHashAddress.php

@@ -29,7 +29,7 @@ public function __construct(BufferInterface $data)
      * @param NetworkInterface $network
      * @return string
      */
-    public function getPrefixByte(NetworkInterface $network = null): string
+    public function getPrefixByte(?NetworkInterface $network = null): string
     {
         $network = $network ?: Bitcoin::getNetwork();
         return pack("H*", $network->getAddressByte());

src/Address/ScriptHashAddress.php

@@ -29,7 +29,7 @@ public function __construct(BufferInterface $data)
      * @param NetworkInterface $network
      * @return string
      */
-    public function getPrefixByte(NetworkInterface $network = null): string
+    public function getPrefixByte(?NetworkInterface $network = null): string
     {
         $network = $network ?: Bitcoin::getNetwork();
         return pack("H*", $network->getP2shByte());