fix(ci): added some tests to CI and pre-commit, that were missed earlier (#458)

Author: milindsrivastava1997

.github/workflows/correctness.yml

@@ -140,31 +140,3 @@ jobs:
       - name: Compare serialised patterns
         working-directory: asap-common/tests/compare_patterns
         run: python compare_serialized_patterns.py
-
-  # ── 3. Rust pattern-matching unit tests ────────────────────────────────────
-  rust-pattern-matching:
-    if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
-    name: Rust pattern matching unit tests
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
-
-      - name: Install protoc
-        run: |
-          sudo apt-get update -qq
-          sudo apt-get install -y protobuf-compiler
-
-      - name: Run sccache
-        uses: mozilla-actions/sccache-action@v0.0.4
-
-      - name: Cache cargo
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target
-          key: ${{ runner.os }}-cargo-correctness-${{ hashFiles('**/Cargo.lock', '**/Cargo.toml') }}

.github/workflows/python.yml

@@ -8,6 +8,7 @@ on:
       - 'asap-tools/**'
       - 'asap-tools/data-sources/prometheus-exporters/**'
       - 'asap-tools/execution-utilities/**'
+      - 'asap-summary-ingest/**'
       - 'asap-common/dependencies/py/**'
       - '.github/workflows/python.yml'
   pull_request:
@@ -18,6 +19,7 @@ on:
       - 'asap-tools/**'
       - 'asap-tools/data-sources/prometheus-exporters/**'
       - 'asap-tools/execution-utilities/**'
+      - 'asap-summary-ingest/**'
       - 'asap-common/dependencies/py/**'
       - '.github/workflows/python.yml'
   workflow_dispatch:
@@ -39,6 +41,7 @@ jobs:
       utilities: ${{ steps.filter.outputs.utilities }}
       prometheus_exporters: ${{ steps.filter.outputs.prometheus_exporters }}
       execution_utilities: ${{ steps.filter.outputs.execution_utilities }}
+      summary_ingest: ${{ steps.filter.outputs.summary_ingest }}
     steps:
       - uses: actions/checkout@v4
       - uses: dorny/paths-filter@v2
@@ -57,6 +60,9 @@ jobs:
             execution_utilities:
               - 'asap-tools/execution-utilities/**'
               - 'asap-common/dependencies/py/**'
+            summary_ingest:
+              - 'asap-summary-ingest/**'
+              - 'asap-common/dependencies/py/**'
 
   test-prometheus-client:
     needs: detect-changes
@@ -182,3 +188,21 @@ jobs:
         flake8 . --config=../../.flake8 --count --select=E9,F63,F7,F82 --show-source --statistics
         # Exit-zero treats all errors as warnings
         flake8 . --config=../../.flake8 --count --exit-zero --max-complexity=10 --statistics
+
+  test-summary-ingest:
+    needs: detect-changes
+    if: needs.detect-changes.outputs.summary_ingest == 'true'
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.11'
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install -e asap-common/dependencies/py/promql_utilities/
+        pip install pytest pyyaml jinja2
+    - name: Run pytest
+      run: python -m pytest asap-summary-ingest/tests/ -v

.github/workflows/rust.yml

@@ -5,6 +5,7 @@ on:
     branches: [ main ]
     paths:
       - 'asap-query-engine/**'
+      - 'asap-planner-rs/**'
       - 'asap-common/dependencies/rs/**'
       - 'asap-common/tests/**'
       - 'asap-common/sketch-core/**'
@@ -16,6 +17,7 @@ on:
     branches: [ main ]
     paths:
       - 'asap-query-engine/**'
+      - 'asap-planner-rs/**'
       - 'asap-common/dependencies/rs/**'
       - 'asap-common/tests/**'
       - 'asap-common/sketch-core/**'

.pre-commit-config.yaml

@@ -100,3 +100,11 @@ repos:
         language: system
         files: \.rs$
         pass_filenames: false
+
+      - id: pytest-summary-ingest
+        name: pytest (asap-summary-ingest)
+        description: Run asap-summary-ingest unit tests against vendored promql_utilities.
+        entry: bash -c 'pip install -q -e asap-common/dependencies/py/promql_utilities/ && python3 -m pytest asap-summary-ingest/tests/'
+        language: system
+        files: ^(asap-summary-ingest|asap-common/dependencies/py)/
+        pass_filenames: false