Update CI (#33)

* Update CI

* Remove missing test suite

* Replace serialize method

* Fix CS

* Update readme

Author: malberts

.github/workflows/ci.yml

@@ -7,18 +7,35 @@ on:
 jobs:
   test:
     name: "PHPUnit: MW ${{ matrix.mw }}, PHP ${{ matrix.php }}"
+    continue-on-error: ${{ matrix.experimental }}
 
     strategy:
       matrix:
         include:
           - mw: 'REL1_36'
             php: 8.0
+            experimental: false
           - mw: 'REL1_37'
             php: 8.0
+            experimental: false
           - mw: 'REL1_38'
             php: 8.0
+            experimental: false
           - mw: 'REL1_39'
             php: 8.0
+            experimental: false
+          - mw: 'REL1_41'
+            php: 8.1
+            experimental: false
+          - mw: 'REL1_42'
+            php: 8.2
+            experimental: false
+          - mw: 'REL1_43'
+            php: 8.3
+            experimental: false
+          - mw: 'master'
+            php: 8.4
+            experimental: true
 
     runs-on: ubuntu-latest
 

README.md

@@ -186,9 +186,9 @@ Rules are applied in order. In other words, the second Rule can override values
 
 Platform requirements:
 
-* [PHP] 7.4 or later (tested up to 8.0)
-* [MediaWiki] 1.35 or later (tested up to 1.37)
-* [Wikibase] 1.35 or later (tested up to 1.37)
+* [PHP] 7.4 or later (tested up to 8.3)
+* [MediaWiki] 1.35 or later (tested up to 1.43)
+* [Wikibase] 1.35 or later (tested up to 1.43)
 
 The recommended way to install Automated Values is using [Composer] with
 [MediaWiki's built-in support for Composer][Composer install].

phpunit.xml.dist

@@ -6,9 +6,6 @@
 		<testsuite name="Integration">
 			<directory>tests/Integration</directory>
 		</testsuite>
-		<testsuite name="TestExampleRules">
-			<file>tests/TestExampleRules.php</file>
-		</testsuite>
 		<testsuite name="MediaWiki">
 			<directory>tests/MediaWiki</directory>
 		</testsuite>

src/DataAccess/PageContentFetcher.php

@@ -19,8 +19,7 @@ public function __construct( \TitleParser $titleParser, RevisionLookup $revision
 	public function getPageContent( string $pageTitle ): ?\Content {
 		try {
 			$title = $this->titleParser->parseTitle( $pageTitle );
-		}
-		catch ( \MalformedTitleException $e ) {
+		} catch ( \MalformedTitleException $e ) {
 			return null;
 		}
 

src/DataAccess/RulesDeserializer.php

@@ -61,7 +61,7 @@ private function newRules( array $arrayRules ): Rules {
 	private function newEntityCriteria( array $arrayRule ): EntityCriteria {
 		return new EntityCriteria(
 			...array_map(
-				fn( array $criterion ) => new StatementEqualityCriterion( Compat::newPId( $criterion['statement'] ), new StringValue( $criterion['equalTo'] ) ),
+				fn ( array $criterion ) => new StatementEqualityCriterion( Compat::newPId( $criterion['statement'] ), new StringValue( $criterion['equalTo'] ) ),
 				$arrayRule['when'] ?? []
 			)
 		);

src/Domain/Template.php

@@ -41,7 +41,7 @@ public function buildValues( StatementList $statements ): array {
 	public function supportsMultipleValues(): bool {
 		return count( array_unique(
 				array_map(
-					fn( TemplateSegment $s ) => $s->statementPropertyId,
+					fn ( TemplateSegment $s ) => $s->statementPropertyId,
 					$this->segments
 				)
 			) ) === 1;
@@ -57,7 +57,7 @@ private function buildMultipleValues( StatementList $statements ): array {
 			$values[] = $this->buildValue( new StatementList( $statement ) );
 		}
 
-		return array_filter( $values, fn( string $s ) => $s !== '' );
+		return array_filter( $values, fn ( string $s ) => $s !== '' );
 	}
 
 }

src/Domain/TemplateSegment.php

@@ -51,7 +51,7 @@ private function getValuesForSegment( StatementList $statements ): array {
 			$values[] = $this->getValueFromSegment( $statement );
 		}
 
-		return array_filter( $values, fn( $v ) => $v !== null );
+		return array_filter( $values, fn ( $v ) => $v !== null );
 	}
 
 	private function getValueFromSegment( Statement $statement ): ?DataValue {

src/Hooks.php

@@ -18,15 +18,13 @@ class Hooks {
 	public static function onMultiContentSave( RenderedRevision $renderedRevision ): void {
 		try {
 			$content = $renderedRevision->getRevision()->getSlot( 'main' )->getContent();
-		}
-		catch ( RevisionAccessException $ex ) {
+		} catch ( RevisionAccessException $ex ) {
 		}
 
 		if ( isset( $content ) && $content instanceof EntityContent ) {
 			try {
 				$entity = $content->getEntity();
-			}
-			catch ( \Exception $ex ) {
+			} catch ( \Exception $ex ) {
 			}
 
 			if ( isset( $entity ) && $entity instanceof StatementListProvidingEntity ) {

tests/MediaWiki/AutomatedValuesMwTestCase.php

@@ -20,7 +20,7 @@ protected function privateSaveAndLoadProperty( Property $property ): Property {
 
 	private function saveProperty( Property $property ) {
 		$this->insertPage(
-			'Property:' . $property->getId()->serialize(),
+			'Property:' . $property->getId()->getSerialization(),
 			json_encode( $this->getPropertySerializer()->serialize( $property ) )
 		);
 	}