Classify partitioned table/index as unsupported, not untested

Verified directly: pg_get_object_address('partitioned table', ...) throws
"unrecognized object type" -- PostgreSQL's real object-address API only
knows the base "table"/"index" object types cat_tools's "partitioned table"/
"partitioned index" are derived from. object_reference actively calls
pg_get_object_address() on every object_type it tracks (not just in the
disabled sanity CHECK), so these two types would break identity tracking
outright rather than merely lacking test coverage -- the earlier "untested"
classification undersold the actual constraint.

Matches the classification (and the exact reasoning/wording) already landed
independently on the separate, longer-running new_features branch (PR #2),
which reaches unsupported() via the same cat_tools 0.3.0 enum growth. Update
test/sql/all.sql's own sanity-check of the unsupported set to match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: jnasbyupgrade

sql/object_reference--stable.sql

@@ -523,7 +523,12 @@ SELECT __object_reference.create_function(
   , $body$
 SELECT cat_tools.objects__shared()
   || cat_tools.objects__address_unsupported()
-  || '{event trigger}'
+  /*
+   * pg_get_object_address() doesn't recognize "partitioned table" or
+   * "partitioned index" (only the base "table"/"index" types it derives
+   * from), so object identity tracking can't round-trip them.
+   */
+  || '{event trigger, partitioned table, partitioned index}'
 $body$
   , 'Returns array of object types that are not supported.'
   , 'object_reference__usage'
@@ -572,8 +577,7 @@ foreign table, foreign table column, aggregate, collation, conversion, language,
 large object, operator, operator class, operator family, operator of access method,
 function of access method, rule, text search parser, text search dictionary,
 text search template, text search configuration, foreign-data wrapper, server,
-user mapping, default acl, transform, access method, extension, policy,
-partitioned table, partitioned index
+user mapping, default acl, transform, access method, extension, policy
 }'::cat_tools.object_type[]
 $body$
   , 'Returns array of object types that have not been tested.'

sql/object_reference.sql

@@ -522,7 +522,12 @@ SELECT __object_reference.create_function(
   , $body$
 SELECT cat_tools.objects__shared()
   || cat_tools.objects__address_unsupported()
-  || '{event trigger}'
+  /*
+   * pg_get_object_address() doesn't recognize "partitioned table" or
+   * "partitioned index" (only the base "table"/"index" types it derives
+   * from), so object identity tracking can't round-trip them.
+   */
+  || '{event trigger, partitioned table, partitioned index}'
 $body$
   , 'Returns array of object types that are not supported.'
   , 'object_reference__usage'
@@ -571,8 +576,7 @@ foreign table, foreign table column, aggregate, collation, conversion, language,
 large object, operator, operator class, operator family, operator of access method,
 function of access method, rule, text search parser, text search dictionary,
 text search template, text search configuration, foreign-data wrapper, server,
-user mapping, default acl, transform, access method, extension, policy,
-partitioned table, partitioned index
+user mapping, default acl, transform, access method, extension, policy
 }'::cat_tools.object_type[]
 $body$
   , 'Returns array of object types that have not been tested.'

test/expected/zzz_build.out

@@ -21,9 +21,9 @@ psql:test/temp_load.not_sql:512: WARNING:  I promise you will be sorry if you tr
 
 
 
-psql:test/temp_load.not_sql:620: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:624: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
-psql:test/temp_load.not_sql:627: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:631: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
 
 

test/sql/all.sql

@@ -53,6 +53,13 @@ SELECT bag_eq(
       UNION -- Intentionally not UNION ALL; we want to know if object_reference.unsupported has dupes
       SELECT * FROM cat_tools.objects__address_unsupported_srf()
       UNION SELECT 'event trigger'
+      /*
+       * pg_identify_object_as_address() returns these as plain "table"/"index",
+       * and pg_get_object_address() doesn't recognize "partitioned table" or
+       * "partitioned index" at all, so the round-trip is broken.
+       */
+      UNION SELECT 'partitioned table'
+      UNION SELECT 'partitioned index'
     $$
   , 'Verify object_reference.unsupported()'
 );