diff --git a/Makefile b/Makefile index 8b37be9..341b9c3 100644 --- a/Makefile +++ b/Makefile @@ -17,21 +17,25 @@ install: deps # never updated for the Postgres-Extensions/cat_tools fork; `pgxn install # cat_tools` therefore installs an ancient 0.2.1 lacking the function we need # (and carrying a pre-omit_column-fix catalog query that breaks on PG12+). -# 0.3.0 itself has not been tagged/published to PGXN yet -- only 0.2.2/0.2.3 -# are there, and even 0.2.3 predates this function. So PGXN isn't a usable -# install source right now. +# 0.3.0 is now a real tag on GitHub (Postgres-Extensions/cat_tools), but it +# still has NOT been published to PGXN -- only 0.2.2/0.2.3 are there, and even +# 0.2.3 predates this function. So PGXN isn't a usable install source yet. +# IMPORTANT: this being tagged on GitHub does NOT unblock cutting a real +# extension_drop PGXN release -- RELEASE.md's rule is that cat_tools must be +# genuinely pgxn-installable, and a GitHub tag isn't that. # # Building straight from a git ref instead of PGXN is a supported way to # depend on an extension here, not just a one-off hack -- reach for it again # whenever a dependency's real state has moved ahead of what's tagged on # PGXN. What IS temporary is depending on cat_tools this way at all: -# CAT_TOOLS_GIT_REF tracks cat_tools' `master` directly rather than a pinned -# commit, since the function we need doesn't exist on any tagged release, so -# there's nothing more stable to pin to yet. Once 0.3.0 is tagged and -# published to PGXN, revert *this target* to a plain -# `pgxn install 'cat_tools>=0.3.0' --sudo`; leave the git-source mechanism -# itself in place for reuse if this happens again. -CAT_TOOLS_GIT_REF = master +# CAT_TOOLS_GIT_REF now pins the `0.3.0` tag (previously this tracked +# cat_tools' `master` branch directly, back when 0.3.0 hadn't been tagged yet +# and there was nothing more stable to point at). A tag is a fixed, +# intentional reference rather than a moving branch pointer, so prefer it now +# that one exists. Once 0.3.0 is published to PGXN, revert *this target* to a +# plain `pgxn install 'cat_tools>=0.3.0' --sudo`; leave the git-source +# mechanism itself in place for reuse if this happens again. +CAT_TOOLS_GIT_REF = 0.3.0 CAT_TOOLS_BUILD_DIR = tmp/cat_tools-build .PHONY: cat_tools