Update Rails to v7.2 (decidim#14784)

alecslupu · andreslucena · web-flow · commit a6e0decca322 · 2025-06-04T13:39:12.000+02:00
* Bump Rails to v7.2 * Set branch * Set rails 7.1 defaults * Successfully generate test_app * Fix (Taxonomies): PG::UndefinedFunction: ERROR: operator does not exist: integer[] @> text[] * Fix activeStorage url * Fix: PG::SyntaxError: ERROR: syntax error at or near "{" LINE 1: ..."decidim_users"."type" = $1 AND (extended_data @> {"ephemera... * Fix: PG::SyntaxError: ERROR: syntax error at or near "{" LINE 1: ...dim_action_logs"."resource_id" = $2 AND (extra @> {"edit":tr... * Fix: private method `warn' called for class ActiveSupport::Deprecation * Fix: PG::SyntaxError: ERROR: syntax error at or near "$3" LINE 1: ...ings->'global'->>'geocoding_enabled')::boolean is $3 or mani... * Fix: Unable to find link or button with id dc-dialog-accept * Fix encoding issues on TimeWithZone * Fix: PG::NotNullViolation: ERROR: null value in column "record_id" of relation "active_storage_attachments" violates not-null constraint * ArgumentError: Decidim::Proposals::Proposal model aliases `state`, but `state` is not an attribute. Use `alias_method :internal_state, :state` or define the method manually. (ArgumentError) * Disable job processing * Fix flaky specs caused by jobs not being finished when assertion is performed * Running rubocops * Update decidim-generators/lib/decidim/generators/app_generator.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Attempt to fix the Comments specs * Attempt to fix the Comments specs #2 * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update active_job.rb --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -96,7 +96,7 @@ PATH
       premailer-rails (~> 1.10)
       rack (~> 2.2, >= 2.2.8.1)
       rack-attack (~> 6.0)
-      rails (~> 7.1.0)
+      rails (~> 7.2.0)
       rails-i18n (~> 7.0)
       ransack (~> 4.2.0)
       redis (~> 4.1)
@@ -203,104 +203,98 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actioncable (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       nio4r (~> 2.0)
       websocket-driver (>= 0.6.1)
       zeitwerk (~> 2.6)
-    actionmailbox (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (>= 2.7.1)
-      net-imap
-      net-pop
-      net-smtp
-    actionmailer (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      mail (~> 2.5, >= 2.5.4)
-      net-imap
-      net-pop
-      net-smtp
+    actionmailbox (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activejob (= 7.2.2.1)
+      activerecord (= 7.2.2.1)
+      activestorage (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      mail (>= 2.8.0)
+    actionmailer (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      actionview (= 7.2.2.1)
+      activejob (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      mail (>= 2.8.0)
       rails-dom-testing (~> 2.2)
-    actionpack (7.1.5.1)
-      actionview (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionpack (7.2.2.1)
+      actionview (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       nokogiri (>= 1.8.5)
       racc
-      rack (>= 2.2.4)
+      rack (>= 2.2.4, < 3.2)
       rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    actiontext (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+      useragent (~> 0.16)
+    actiontext (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activerecord (= 7.2.2.1)
+      activestorage (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       globalid (>= 0.6.0)
       nokogiri (>= 1.8.5)
-    actionview (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    actionview (7.2.2.1)
+      activesupport (= 7.2.2.1)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
     active_link_to (1.0.5)
       actionpack
       addressable
-    activejob (7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activejob (7.2.2.1)
+      activesupport (= 7.2.2.1)
       globalid (>= 0.3.6)
-    activemodel (7.1.5.1)
-      activesupport (= 7.1.5.1)
-    activerecord (7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activemodel (7.2.2.1)
+      activesupport (= 7.2.2.1)
+    activerecord (7.2.2.1)
+      activemodel (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       timeout (>= 0.4.0)
-    activestorage (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    activestorage (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activejob (= 7.2.2.1)
+      activerecord (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       marcel (~> 1.0)
-    activesupport (7.1.5.1)
+    activesupport (7.2.2.1)
       base64
       benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
       logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
       securerandom (>= 0.3)
-      tzinfo (~> 2.0)
+      tzinfo (~> 2.0, >= 2.0.5)
     acts_as_list (1.2.4)
       activerecord (>= 6.1)
       activesupport (>= 6.1)
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.2)
-    base64 (0.2.0)
+    base64 (0.3.0)
     batch-loader (2.0.5)
     bcrypt (3.1.20)
-    benchmark (0.4.0)
+    benchmark (0.4.1)
     better_html (2.1.1)
       actionview (>= 6.0)
       activesupport (>= 6.0)
       ast (~> 2.0)
       erubi (~> 1.4)
       parser (>= 2.4)
       smart_properties
-    bigdecimal (3.1.9)
+    bigdecimal (3.2.1)
     bindex (0.8.1)
     bootsnap (1.18.4)
       msgpack (~> 1.2)
@@ -516,7 +510,7 @@ GEM
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
-    logger (1.6.5)
+    logger (1.7.0)
     loofah (2.24.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
@@ -537,7 +531,6 @@ GEM
     msgpack (1.7.5)
     multi_xml (0.7.1)
       bigdecimal (~> 3.1)
-    mutex_m (0.3.0)
     net-http (0.6.0)
       uri
     net-imap (0.5.8)
@@ -644,20 +637,20 @@ GEM
     rackup (1.0.1)
       rack (< 3)
       webrick
-    rails (7.1.5.1)
-      actioncable (= 7.1.5.1)
-      actionmailbox (= 7.1.5.1)
-      actionmailer (= 7.1.5.1)
-      actionpack (= 7.1.5.1)
-      actiontext (= 7.1.5.1)
-      actionview (= 7.1.5.1)
-      activejob (= 7.1.5.1)
-      activemodel (= 7.1.5.1)
-      activerecord (= 7.1.5.1)
-      activestorage (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
+    rails (7.2.2.1)
+      actioncable (= 7.2.2.1)
+      actionmailbox (= 7.2.2.1)
+      actionmailer (= 7.2.2.1)
+      actionpack (= 7.2.2.1)
+      actiontext (= 7.2.2.1)
+      actionview (= 7.2.2.1)
+      activejob (= 7.2.2.1)
+      activemodel (= 7.2.2.1)
+      activerecord (= 7.2.2.1)
+      activestorage (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
       bundler (>= 1.15.0)
-      railties (= 7.1.5.1)
+      railties (= 7.2.2.1)
     rails-controller-testing (1.0.5)
       actionpack (>= 5.0.1.rc1)
       actionview (>= 5.0.1.rc1)
@@ -672,16 +665,16 @@ GEM
     rails-i18n (7.0.10)
       i18n (>= 0.7, < 2)
       railties (>= 6.0.0, < 8)
-    railties (7.1.5.1)
-      actionpack (= 7.1.5.1)
-      activesupport (= 7.1.5.1)
-      irb
+    railties (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     ransack (4.2.1)
       activerecord (>= 6.1.5)
       activesupport (>= 6.1.5)
@@ -695,7 +688,7 @@ GEM
     redcarpet (3.6.0)
     redis (4.8.1)
     regexp_parser (2.10.0)
-    reline (0.6.0)
+    reline (0.6.1)
       io-console (~> 0.5)
     request_store (1.7.0)
       rack (>= 1.4)
@@ -832,6 +825,7 @@ GEM
     unicode-emoji (4.0.4)
     uniform_notifier (1.16.0)
     uri (1.0.2)
+    useragent (0.16.11)
     valid_email2 (7.0.0)
       activemodel (>= 6.0)
       mail (~> 2.5)
diff --git a/decidim-blogs/spec/shared/manage_posts_examples.rb b/decidim-blogs/spec/shared/manage_posts_examples.rb
@@ -64,6 +64,8 @@
       expect(page).to have_content("created the #{translated(attributes[:title])} blog post")
     end
 
+    perform_enqueued_jobs
+
     visit decidim.last_activities_path
     expect(page).to have_content("New post: #{translated(attributes[:title])}")
 
diff --git a/decidim-comments/app/models/decidim/comments/comment.rb b/decidim-comments/app/models/decidim/comments/comment.rb
@@ -208,7 +208,7 @@ def deleted?
       end
 
       def edited?
-        Decidim::ActionLog.where(resource: self).exists?(["extra @> ?", Arel.sql("{\"edit\":true}")])
+        Decidim::ActionLog.where(resource: self).exists?(["extra @> ?", { edit: true }.to_json])
       end
 
       def extra_actions_for(current_user)
diff --git a/decidim-core/app/commands/decidim/update_account.rb b/decidim-core/app/commands/decidim/update_account.rb
@@ -56,7 +56,7 @@ def update_personal_data
 
     def update_avatar
       if @form.avatar.present?
-        current_user.avatar.attach(@form.avatar)
+        current_user.avatar.attach(@form.avatar.signed_id)
       elsif @form.remove_avatar
         current_user.avatar = nil
       end
diff --git a/decidim-core/app/controllers/decidim/application_controller.rb b/decidim-core/app/controllers/decidim/application_controller.rb
@@ -68,6 +68,8 @@ def store_share_token
 
     private
 
+    def allow_browser(**); end
+
     # This overrides Devise's method for extracting the path from the URL. We
     # want to ensure the path to be stored in the cookie is not too long in
     # order to avoid ActionDispatch::Cookies::CookieOverflow exception. If the
diff --git a/decidim-core/app/models/decidim/taxonomy.rb b/decidim-core/app/models/decidim/taxonomy.rb
@@ -53,7 +53,7 @@ class Taxonomy < ApplicationRecord
     }
 
     scope :part_of, lambda { |id|
-      where("part_of @> ARRAY[?]", id.to_i)
+      where("part_of @> ARRAY[?]::integer[]", id.to_i)
     }
 
     def self.log_presenter_class_for(_log)
diff --git a/decidim-core/app/models/decidim/user.rb b/decidim-core/app/models/decidim/user.rb
@@ -57,7 +57,7 @@ def self.all
 
     scope :org_admins_except_me, ->(user) { where(organization: user.organization, admin: true).where.not(id: user.id) }
 
-    scope :ephemeral, -> { where("extended_data @> ?", Arel.sql({ ephemeral: true }.to_json)) }
+    scope :ephemeral, -> { where("extended_data @> ?", { ephemeral: true }.to_json) }
 
     scope :with_inactivity_notification, lambda {
       where("extended_data ? 'inactivity_notification'")
diff --git a/decidim-core/decidim-core.gemspec b/decidim-core/decidim-core.gemspec
@@ -73,7 +73,7 @@ Gem::Specification.new do |s|
   s.add_dependency "premailer-rails", "~> 1.10"
   s.add_dependency "rack", "~> 2.2", ">= 2.2.8.1"
   s.add_dependency "rack-attack", "~> 6.0"
-  s.add_dependency "rails", "~> 7.1.0"
+  s.add_dependency "rails", "~> 7.2.0"
   s.add_dependency "rails-i18n", "~> 7.0"
   s.add_dependency "ransack", "~> 4.2.0"
   s.add_dependency "redis", "~> 4.1"
diff --git a/decidim-core/lib/decidim/api/input_filters/component_input_filter.rb b/decidim-core/lib/decidim/api/input_filters/component_input_filter.rb
@@ -35,13 +35,13 @@ class ComponentInputFilter < BaseInputFilter
 
       def self.prepare_comments_enabled(active, _ctx)
         lambda do |_model_name, _locale|
-          ["(settings->'global'->>'comments_enabled')::boolean is ?", active]
+          ["settings @> ?", { global: { comments_enabled: active } }.to_json]
         end
       end
 
       def self.prepare_geolocation_enabled(active, _ctx)
         lambda do |_model_name, _locale|
-          ["(settings->'global'->>'geocoding_enabled')::boolean is ? or manifest_name='meetings'", active]
+          ["settings @> ? or manifest_name='meetings'", { global: { geocoding_enabled: active } }.to_json]
         end
       end
 
diff --git a/decidim-core/lib/decidim/attributes/time_with_zone.rb b/decidim-core/lib/decidim/attributes/time_with_zone.rb
@@ -33,7 +33,7 @@ def cast_value(value)
         return fallback unless fallback.is_a?(Time)
         return Time.zone.parse(fallback.strftime("%F %T")) if ISO_DATETIME_WITHOUT_TIMEZONE.match?(value)
 
-        ActiveSupport::TimeWithZone.new(fallback, Time.zone)
+        fallback
       end
     end
   end
diff --git a/decidim-core/lib/decidim/core.rb b/decidim-core/lib/decidim/core.rb
@@ -1037,4 +1037,8 @@ def self.module_installed?(mod)
   rescue LoadError
     false
   end
+
+  def self.deprecator(gem_name: "decidim-core", deprecation_horizon: "0.32")
+    @deprecator ||= ActiveSupport::Deprecation.new(deprecation_horizon, gem_name)
+  end
 end
diff --git a/decidim-core/lib/decidim/core/engine.rb b/decidim-core/lib/decidim/core/engine.rb
@@ -250,7 +250,7 @@ def named_variants
 
           ActiveSupport.on_load(:active_storage_attachment) { prepend Attachment }
         else
-          ActiveSupport::Deprecation.warn("Remove decidim_core.active_storage_method_patch initializer from #{__FILE__}")
+          Decidim.deprecator.warn("Remove decidim_core.active_storage_method_patch initializer from #{__FILE__}")
         end
       end
 
@@ -421,7 +421,7 @@ def named_variants
 
         next unless legacy_api_key
 
-        ActiveSupport::Deprecation.warn(
+        Decidim.deprecator.warn(
           <<~DEPRECATION.strip
             Configuring maps functionality has changed.
 
diff --git a/decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb b/decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
@@ -192,9 +192,10 @@
       end
 
       it "shows a modal with the comment form" do
-        sleep 1
+        sleep(2)
+        expect(page).to have_content("Add comment")
         click_on "Add comment"
-        sleep 1
+
         expect(page).to have_content("Add comment")
         expect(page).to have_content("1000 characters left")
         expect(page).to have_css(".add-comment form")
diff --git a/decidim-core/lib/decidim/deprecations.rb b/decidim-core/lib/decidim/deprecations.rb
@@ -11,7 +11,7 @@ module Deprecations
     # @param [Symbol] replacement - name of the new method to use
     def deprecated_alias(old_name, replacement)
       define_method(old_name) do |*args, &block|
-        ActiveSupport::Deprecation.warn "##{old_name} deprecated (please use ##{replacement})"
+        Decidim.deprecator.warn "##{old_name} deprecated (please use ##{replacement})"
         send replacement, *args, &block
       end
     end
diff --git a/decidim-core/lib/decidim/icon_registry.rb b/decidim-core/lib/decidim/icon_registry.rb
diff --git a/decidim-core/lib/decidim/map/provider/static_map/here.rb b/decidim-core/lib/decidim/map/provider/static_map/here.rb
diff --git a/decidim-core/lib/decidim/menu.rb b/decidim-core/lib/decidim/menu.rb
diff --git a/decidim-dev/lib/decidim/dev/test/rspec_support/active_job.rb b/decidim-dev/lib/decidim/dev/test/rspec_support/active_job.rb
diff --git a/decidim-generators/Gemfile.lock b/decidim-generators/Gemfile.lock
diff --git a/decidim-generators/lib/decidim/generators/app_generator.rb b/decidim-generators/lib/decidim/generators/app_generator.rb
diff --git a/decidim-initiatives/spec/system/edit_initiative_spec.rb b/decidim-initiatives/spec/system/edit_initiative_spec.rb

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class Taxonomy < ApplicationRecord`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`scope :part_of, lambda { \|id\|`
`56`		`- where("part_of @> ARRAY[?]", id.to_i)`
	`56`	`+ where("part_of @> ARRAY[?]::integer[]", id.to_i)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`def self.log_presenter_class_for(_log)`