Reformating#39
Merged
Merged
Conversation
- some small mypy fixes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs comprehensive code reformatting across the PoorWSGI project, standardizing code style and fixing several type hint issues. The changes include converting single quotes to double quotes throughout the codebase, applying consistent formatting (likely using Black/Ruff), and significantly expanding project documentation.
Key Changes:
- Applied consistent code formatting with double quotes and improved line breaks throughout
poorwsgi/request.pyand related files - Fixed type hints for
secret_key,path_args, andargssetters to correctly reflect accepted types - Corrected
license_filesinsetup.pyfrom string to list format - Completely rewrote and expanded
CONTRIBUTION.rstwith comprehensive contribution guidelines including TDD approach and pre-commit setup - Added new
ARCHITECTURE.rstfile documenting the internal framework architecture - Removed
.travis.yml(likely transitioning to a different CI system)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Changed path concatenation to path.join() and fixed license_files to use list format |
| poorwsgi/wsgi.py | Fixed secret_key setter type hint to accept Union[str, bytes] |
| poorwsgi/request.py | Reformatted quotes to double quotes, improved line breaks, fixed type hints for path_args and args setters |
| CONTRIBUTION.rst | Complete rewrite with comprehensive contribution guidelines, TDD approach, and development setup instructions |
| ARCHITECTURE.rst | New file documenting framework architecture, core objects, and request-response lifecycle |
| .travis.yml | Removed Travis CI configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.