fix file loger on command line

Author: Gin

Common/Cpp/Logging/FileLogger.cpp

@@ -133,6 +133,17 @@ void FileLogger::thread_loop(){
             return m_stopping || !m_queue.empty();
         });
         if (m_stopping){
+            if (m_config.flush_when_exit && m_file.is_open()){
+                while(m_queue.size() > 0){
+                    std::string msg = std::move(m_queue.front().first);
+                    // Write to file
+                    std::string line = normalize_newlines(msg);
+                    std::string file_str = to_file_str(line);
+                    m_file.write(file_str.c_str(), file_str.size());
+                    m_queue.pop_front();
+                }
+                m_file.flush();
+            }
             break;
         }
         auto& item = m_queue.front();

Common/Cpp/Logging/FileLogger.h

@@ -28,6 +28,7 @@ struct FileLoggerConfig{
     size_t max_queue_size = 10000;                  // Max pending log entries before blocking
     size_t max_file_size_bytes = 50 * 1024 * 1024;  // Max file size before rotation (50MB default)
     size_t last_log_max_lines = 10000;              // Max lines to keep in memory for get_last()
+    bool flush_when_exit = false;                   // Whether to save remaining logs to file when program exists
 };
 
 

Common/Cpp/Logging/GlobalLogger.cpp

@@ -13,14 +13,12 @@ static FileLoggerConfig _global_logger_config;
 
 void initialize_global_logger(FileLoggerConfig config){
     _global_logger_config = std::move(config);
-    // auto& logger = global_logger_raw();
-    // logger.log("Initialized logger with path " + config.file_path);
 }
 
 Logger& global_logger_raw(){
     auto get_config = [&](){
         if (_global_logger_config.file_path.size() == 0){
-            _global_logger_config.file_path = ".";
+            _global_logger_config.file_path = "./SerialPrograms.log";
         }
         return _global_logger_config;
     };

Common/Cpp/Logging/GlobalLogger.h

@@ -16,15 +16,15 @@ namespace PokemonAutomation{
 
 // Call this function at very beginning of the main function to initialize the global file logger.
 // Call `global_logger_raw()` to retrieve the global file logger afterwards.
-// If not called, a default logger with default file path of "." will be created.
+// If not called, a default logger with default file path of "./SerialPrograms.log" will be created.
 void initialize_global_logger(FileLoggerConfig config);
 
 
 // Return a global raw `FileLogger`. `FileLogger` is defined in FileLogger.h.
 // "raw" here means the logger does not add any timestamp or tags to the incoming log lines.
 // Suggest calling `initialize_global_logger()` at very beginning of the main function to
-// initialize the logger first. Otherwise a default logger with default file path of "."
-// will be created.
+// initialize the logger first. Otherwise a default logger with default file path of
+// "./SerialPrograms.log" will be created.
 Logger& global_logger_raw();
 
 

SerialPrograms/Source/CommandLine/CommandLine_Main.cpp

@@ -17,6 +17,12 @@ using namespace PokemonAutomation;
 using namespace PokemonAutomation::NintendoSwitch;
 
 int main(int argc, char* argv[]){
+    initialize_global_logger(
+        FileLoggerConfig{
+            .file_path = "./SerialProgramsCommandLine.log",
+            .flush_when_exit = true
+        }
+    );
 //     // Set up output redirection for logging
 //     OutputRedirector redirect_stdout(std::cout, "stdout", Color());
 //     OutputRedirector redirect_stderr(std::cerr, "stderr", COLOR_RED);