refactor: eliminate boilerplate in set-matrix steps

Replace repetitive if-blocks with automatic extraction of changed
modules using toJSON() and jq filtering. This drastically reduces
code duplication and maintenance burden.

Changes:
- lint.yml: replace 14 if-blocks (64 lines) with single jq filter (4 lines)
- test-e2e.yml: replace 3 if-blocks with config JSON + jq mapping
- Use toJSON(steps.filter.outputs) to get all filter results
- Use jq to extract only modules where value == "true"
- test-e2e.yml: define module configs in clean JSON format

Author: rafal-k

.github/workflows/lint.yml

@@ -28,23 +28,10 @@ jobs:
     if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
     runs-on: ubuntu-latest
     outputs:
-      payments: ${{ steps.filter.outputs.payments }}
-      user: ${{ steps.filter.outputs.user }}
-      chat: ${{ steps.filter.outputs.chat }}
-      common-styling: ${{ steps.filter.outputs.common-styling }}
-      tests: ${{ steps.filter.outputs.tests }}
-      core: ${{ steps.filter.outputs.core }}
-      oauth-facebook: ${{ steps.filter.outputs.oauth-facebook }}
-      oauth-github: ${{ steps.filter.outputs.oauth-github }}
-      oauth-google: ${{ steps.filter.outputs.oauth-google }}
-      openai: ${{ steps.filter.outputs.openai }}
-      reports: ${{ steps.filter.outputs.reports }}
-      data-export-api: ${{ steps.filter.outputs.data-export-api }}
-      payments-stripe: ${{ steps.filter.outputs.payments-stripe }}
-      payments-example-gateway: ${{ steps.filter.outputs.payments-example-gateway }}
+      changed-modules: ${{ steps.set-matrix.outputs.matrix }}
     steps:
       - uses: actions/checkout@v4
-      
+
       - uses: dorny/paths-filter@v3
         id: filter
         with:
@@ -78,55 +65,38 @@ jobs:
             payments-example-gateway:
               - 'pos-module-payments-example-gateway/**'
 
+      - name: Set matrix for changed modules
+        id: set-matrix
+        run: |
+          # Extract module names where filter output is "true"
+          modules=$(echo '${{ toJSON(steps.filter.outputs) }}' | jq -c '[to_entries[] | select(.value == "true") | .key]')
+
+          echo "matrix=$modules" >> $GITHUB_OUTPUT
+          echo "Changed modules for linting: $modules"
+
   lint-platformos-check:
     needs: detect-changes
+    if: needs.detect-changes.outputs.changed-modules != '[]'
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        module:
-          - payments
-          - user
-          - chat
-          - common-styling
-          - tests
-          - core
-          - oauth-facebook
-          - oauth-github
-          - oauth-google
-          - openai
-          - reports
-          - data-export-api
-          - payments-stripe
-          - payments-example-gateway
+        module: ${{ fromJSON(needs.detect-changes.outputs.changed-modules) }}
       fail-fast: false
     env:
       CI: true
       PLATFORMOS_CHECK_DEBUG: true
       DOCKER_WORKSPACE: ${{ github.workspace }}/pos-module-${{ matrix.module }}
       LOGS_DIR: ${{ github.workspace }}/pos-module-${{ matrix.module }}/logs
     steps:
-      - name: Check if this module changed
-        id: changed
-        run: |
-          MODULE_CHANGED="${{ needs.detect-changes.outputs[matrix.module] }}"
-          if [ "$MODULE_CHANGED" != "true" ]; then
-            echo "skip=true" >> $GITHUB_OUTPUT
-          else
-            echo "skip=false" >> $GITHUB_OUTPUT
-          fi
-
       - name: Checkout code
-        if: steps.changed.outputs.skip != 'true'
         uses: actions/checkout@v4
 
       - name: Set up logs directory
-        if: steps.changed.outputs.skip != 'true'
         run: |
           mkdir -p ${{ env.LOGS_DIR }}
           chmod -R 777 ${{ env.LOGS_DIR }}
 
       - name: Start PlatformOS LSP
-        if: steps.changed.outputs.skip != 'true'
         id: start_lsp
         run: |
           docker run -i \
@@ -137,7 +107,7 @@ jobs:
             platformos/platformos-lsp:latest
 
       - name: Run platformos-check
-        if: steps.changed.outputs.skip != 'true' && steps.start_lsp.outcome == 'success'
+        if: steps.start_lsp.outcome == 'success'
         id: run_check
         run: |
           set +e  # Disable exit on error
@@ -155,7 +125,7 @@ jobs:
           exit $docker_exit_code
 
       - name: Upload logs
-        if: always() && steps.changed.outputs.skip != 'true' && steps.run_check.outcome != 'skipped'
+        if: always() && steps.run_check.outcome != 'skipped'
         uses: actions/upload-artifact@v4
         with:
           name: platformos_check_logs_${{ matrix.module }}_${{ github.run_id }}
@@ -165,7 +135,7 @@ jobs:
             ${{ env.LOGS_DIR }}/platformos-check-raw.json
 
       - name: Generate summary
-        if: always() && steps.changed.outputs.skip != 'true' && steps.run_check.outcome != 'skipped'
+        if: always() && steps.run_check.outcome != 'skipped'
         run: |
           echo "# PlatformOS Check Summary - ${{ matrix.module }} :checkered_flag:" >> $GITHUB_STEP_SUMMARY
           echo "## Result: ${{ steps.run_check.outcome }} ${{ env.RESULT_ICON }}" >> $GITHUB_STEP_SUMMARY
@@ -183,7 +153,7 @@ jobs:
           RESULT_ICON: ${{ steps.run_check.outcome == 'success' && ':white_check_mark:' || ':x:' }}
 
       - name: Fail job if platformos-check failed
-        if: always() && steps.changed.outputs.skip != 'true' && steps.run_check.outcome == 'failure'
+        if: always() && steps.run_check.outcome == 'failure'
         run: |
           echo "platformos-check failed — marking job as failed"
           exit 1

.github/workflows/test-e2e.yml

@@ -45,19 +45,34 @@ jobs:
       - name: Set matrix for changed modules
         id: set-matrix
         run: |
-          modules='[]'
-
-          if [ "${{ steps.filter.outputs.user }}" == "true" ]; then
-            modules=$(echo "$modules" | jq -c '. += [{"module":"user","path":"pos-module-user","deploy-script":"rm app/pos-modules.* || true\nsh ./tests/data/seed/seed.sh","test-commands":"npm run admin-panel-pw-tests\nnpm run pw-tests"}]')
-          fi
-
-          if [ "${{ steps.filter.outputs.chat }}" == "true" ]; then
-            modules=$(echo "$modules" | jq -c '. += [{"module":"chat","path":"pos-module-chat","deploy-script":"rm app/pos-modules.* || true\nsh ./tests/data/seed/seed.sh","test-commands":"npm run pw-tests"}]')
-          fi
-
-          if [ "${{ steps.filter.outputs.common-styling }}" == "true" ]; then
-            modules=$(echo "$modules" | jq -c '. += [{"module":"common-styling","path":"pos-module-common-styling","deploy-script":"pos-cli data clean --include-schema --auto-confirm\npos-cli deploy","test-commands":"npm run pw-tests"}]')
-          fi
+          # Define module configurations
+          cat > /tmp/module-config.json << 'EOF'
+          {
+            "user": {
+              "module": "user",
+              "path": "pos-module-user",
+              "deploy-script": "rm app/pos-modules.* || true\nsh ./tests/data/seed/seed.sh",
+              "test-commands": "npm run admin-panel-pw-tests\nnpm run pw-tests"
+            },
+            "chat": {
+              "module": "chat",
+              "path": "pos-module-chat",
+              "deploy-script": "rm app/pos-modules.* || true\nsh ./tests/data/seed/seed.sh",
+              "test-commands": "npm run pw-tests"
+            },
+            "common-styling": {
+              "module": "common-styling",
+              "path": "pos-module-common-styling",
+              "deploy-script": "pos-cli data clean --include-schema --auto-confirm\npos-cli deploy",
+              "test-commands": "npm run pw-tests"
+            }
+          }
+          EOF
+
+          # Extract changed modules and map to their configurations
+          modules=$(echo '${{ toJSON(steps.filter.outputs) }}' | \
+            jq -c --slurpfile config /tmp/module-config.json \
+            '[to_entries[] | select(.value == "true") | .key as $m | $config[0][$m] | select(. != null)]')
 
           echo "matrix=$modules" >> $GITHUB_OUTPUT
           echo "Changed modules matrix: $modules"