fixes all specs bar one

Author: stakach

spec/controllers/metadata_spec.cr

@@ -79,7 +79,7 @@ module PlaceOS::Api
           headers: Spec::Authentication.headers,
         )
 
-        result.status_code.should eq 201
+        result.success?.should be_true
 
         new_metadata = Model::Metadata::Interface.from_json(result.body)
         found = Model::Metadata.for(parent.id.as(String), meta.name).first
@@ -105,7 +105,7 @@ module PlaceOS::Api
           headers: Spec::Authentication.headers,
         )
 
-        result.status_code.should eq 201
+        result.success?.should be_true
 
         new_metadata = Model::Metadata::Interface.from_json(result.body)
         found = Model::Metadata.for(parent_id, meta.name).first
@@ -125,7 +125,7 @@ module PlaceOS::Api
           headers: Spec::Authentication.headers,
         )
 
-        result.status_code.should eq 200
+        result.success?.should be_true
 
         update_response_meta = Model::Metadata::Interface.from_json(result.body)
         update_response_meta.details.as_h["bye"]?.should be_nil

spec/controllers/modules_spec.cr

@@ -265,7 +265,7 @@ module PlaceOS::Api
           )
 
           result.success?.should be_false
-          result.status_code.should eq 406
+          result.status_code.should eq 422
         end
 
         it "pings a module" do

spec/controllers/system-triggers_spec.cr

@@ -120,7 +120,7 @@ module PlaceOS::Api
         path = SystemTriggers.base_route.gsub(/:sys_id/, sys.id) + id
 
         result = client.delete(path: path, headers: Spec::Authentication.headers)
-        result.status_code.should eq 200
+        result.success?.should be_true
 
         Model::TriggerInstance.find(id.as(String)).should be_nil
       end

spec/controllers/systems_spec.cr

@@ -28,7 +28,7 @@ module PlaceOS::Api
       headers: headers,
     )
 
-    result.status_code.should eq 200
+    result.success?.should be_true
     system = Model::ControlSystem.from_trusted_json(result.body)
     system.modules.should_not contain mod_id
     system

src/placeos-rest-api/controllers/api_keys.cr

@@ -8,7 +8,7 @@ module PlaceOS::Api
     ###############################################################################################
 
     before_action :can_read, only: [:index, :show]
-    before_action :can_write, only: [:create, :update, :destroy, :update_alt]
+    before_action :can_write, only: [:create, :update, :destroy]
 
     before_action :check_admin, except: :inspect_key
 

src/placeos-rest-api/controllers/application.cr

@@ -13,15 +13,18 @@ module PlaceOS::Api
 
     # Customise the request body parser
     add_parser("application/json") do |klass, body_io|
-      if klass.is_a? ActiveModel::Model
-        object = klass.new
+      json = body_io.gets_to_end
+      object = klass.from_json(json)
+
+      # TODO:: try to improve this double parsing
+      if object.is_a?(::PlaceOS::Model::ModelBase)
+        object = object.class.new
         # we clear the changes information so we can track what was assigned from the JSON
         object.clear_changes_information
-        object.assign_attributes_from_json(body_io)
-        object
-      else
-        klass.from_json(body_io)
+        object.assign_attributes_from_json(json)
       end
+
+      object
     end
 
     # Helpers for controller responses
@@ -146,7 +149,7 @@ module PlaceOS::Api
 
     # CONFLICT if there is a version clash
     @[AC::Route::Exception(Error::Conflict, status_code: HTTP::Status::CONFLICT)]
-    def resource_requires_authentication(error) : CommonError
+    def resource_conflict(error) : CommonError
       Log.debug { error.message }
       CommonError.new(error, false)
     end

src/placeos-rest-api/controllers/authentications.cr

@@ -10,7 +10,7 @@ module PlaceOS::Api
       ###############################################################################################
 
       before_action :can_read, only: [:index, :show]
-      before_action :can_write, only: [:create, :update, :destroy, :remove, :update_alt]
+      before_action :can_write, only: [:create, :update, :destroy, :remove]
 
       before_action :check_admin
 

src/placeos-rest-api/controllers/brokers.cr

@@ -10,7 +10,7 @@ module PlaceOS::Api
     ###############################################################################################
 
     before_action :can_read, only: [:collection, :show]
-    before_action :can_write, only: [:create, :update, :destroy, :remove, :update_alt]
+    before_action :can_write, only: [:create, :update, :destroy, :remove]
 
     before_action :check_admin, except: [:collection, :show]
     before_action :check_support, only: [:collection, :show]

src/placeos-rest-api/controllers/domains.cr

@@ -8,7 +8,7 @@ module PlaceOS::Api
     ###############################################################################################
 
     before_action :can_read, only: [:index, :show]
-    before_action :can_write, only: [:create, :update, :destroy, :remove, :update_alt]
+    before_action :can_write, only: [:create, :update, :destroy, :remove]
 
     before_action :check_admin, except: [:index, :show]
     before_action :check_support, only: [:index, :show]

src/placeos-rest-api/controllers/drivers.cr

@@ -8,7 +8,7 @@ module PlaceOS::Api
     ###############################################################################################
 
     before_action :can_read, only: [:index, :show]
-    before_action :can_write, only: [:create, :update, :destroy, :remove, :update_alt]
+    before_action :can_write, only: [:create, :update, :destroy, :remove]
 
     before_action :check_admin, except: [:index, :show]
     before_action :check_support, only: [:index, :show]