fix(transport/http): never stop processing queue in HTTP drivers

Author: stakach

shard.yml

@@ -1,5 +1,5 @@
 name: placeos-driver
-version: 7.11.4
+version: 7.11.5
 
 dependencies:
   action-controller:

spec/transport_http_spec.cr

@@ -4,11 +4,11 @@ describe PlaceOS::Driver::TransportHTTP do
   it "should perform a secure request" do
     responses = 0
     queue = Helper.queue
-    transport = PlaceOS::Driver::TransportHTTP.new(queue, "https://www.google.com.au/", ::PlaceOS::Driver::Settings.new(%({"disable_cookies": true}))) do
+    transport = PlaceOS::Driver::TransportHTTP.new(queue, "https://www.google.com/", ::PlaceOS::Driver::Settings.new(%({"disable_cookies": true}))) do
       responses += 1
     end
     transport.before_request do |request|
-      request.hostname.should eq "www.google.com.au"
+      request.hostname.should eq "www.google.com"
     end
     transport.connect
     queue.online.should eq(true)

src/placeos-driver/transport/http.cr

@@ -144,6 +144,7 @@ class PlaceOS::Driver
     @max_requests : Int32
     @ip : String
     @tls : OpenSSL::SSL::Context::Client?
+    @connected_state : Bool = true
 
     property :received
 
@@ -157,6 +158,18 @@ class PlaceOS::Driver
       @queue.online = true
     end
 
+    # don't stop processing commands in HTTP drivers
+    # the requests are required to re-enable the queue
+    # and queue based HTTP drivers are less common
+    protected def set_connected_state(state : Bool)
+      @connected_state = state
+      if state && !@queue.online
+        @queue.online = true
+      else
+        @queue.set_connected state
+      end
+    end
+
     protected def __is_https?
       (@uri_base.scheme || "http").ends_with?('s')
     end
@@ -257,14 +270,14 @@ class PlaceOS::Driver
                    end
                  end
 
-      # assuming we're typically online, this check before assignment is more performant
-      @queue.online = true unless @queue.online
+      # we don't want to be calling connected callback each time a request succeeds
+      set_connected_state(true) unless @connected_state
       @received.call
 
       # fallback in case the HTTP client lib doesn't decompress the response
       check_http_response_encoding response
     rescue error : IO::Error | ArgumentError
-      @queue.online = false
+      set_connected_state(false)
       raise error
     end