Skip to content

Fix ci-coverage-build.yml job#26

Merged
nbbrooks merged 5 commits into
mainfrom
pr-update-workflow-ubuntu-distro
Dec 14, 2025
Merged

Fix ci-coverage-build.yml job#26
nbbrooks merged 5 commits into
mainfrom
pr-update-workflow-ubuntu-distro

Conversation

@nbbrooks
Copy link
Copy Markdown
Member

@nbbrooks nbbrooks commented Dec 14, 2025

This job is failing, probably for a couple reasons.

  1. Rolling has targeted 24.04 for some time now (similar to Run coverage CI on Ubuntu 24.04 ros2_robotiq_gripper#56)

2. It is also using github.sha to retrieve raw github content, which does not exist for pull_request triggers

  1. It looks like raw github content retrieval with authentication via ?token=${{ secrets.GITHUB_TOKEN }} is no longer supported. Since this is a public repo and I would be surprised if we somehow hit the raw limit for unauthenticated retrieval in CI jobs, I'm just removing it entirely.

The rolling jobs should still fail until #23 is merged in but this shouldn't get stuck on retrieving the vcs file from raw.githubcontent anymore.

@nbbrooks nbbrooks changed the title Update ci-coverage-build.yml rolling job to target 24.04 Fix ci-coverage-build.yml job Dec 14, 2025
…en. I doubt we are going to get rate limited in their repository's CI.
…ual 404 issue was the deprecated appended token syntax
@nbbrooks
Copy link
Copy Markdown
Member Author

The coverage job is now failing at the expected place (same as the other Rolling jobs)

/home/runner/work/picknik_controllers/picknik_controllers/ros_ws/src/nn8lre94e7/picknik_controllers/picknik_reset_fault_controller/src/picknik_reset_fault_controller.cpp:65:51: error: ‘class realtime_tools::RealtimePublisher<example_interfaces::msg::Bool_<std::allocator > >’ has no member named ‘trylock’
65 | if (realtime_publisher_ && realtime_publisher_->trylock())
|

@nbbrooks nbbrooks merged commit df9711c into main Dec 14, 2025
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant