Fix upstream API

[christophfroehlich]

👀 @nbbrooks

Fyi: ABI build fails because the upstream version does not build any more.

[sea-bass]

LGTM but you will need a maintainer to approve for real

[nbbrooks]

I don't understand why the Rolling job is failing, the logs look like it (and maybe the Cover buidl as well) is not using the changes in this PR

  /root/base_ws/src/picknik_controllers/picknik_reset_fault_controller/src/picknik_reset_fault_controller.cpp: In member function ‘virtual controller_interface::return_type picknik_reset_fault_controller::PicknikResetFaultController::update(const rclcpp::Time&, const rclcpp::Duration&)’:
  /root/base_ws/src/picknik_controllers/picknik_reset_fault_controller/src/picknik_reset_fault_controller.cpp:65:51: error: ‘class realtime_tools::RealtimePublisher<example_interfaces::msg::Bool_<std::allocator<void> > >’ has no member named ‘trylock’
     65 |   if (realtime_publisher_ && realtime_publisher_->trylock())

Humble is failing as expected and should not be run against main anymore, since we are breaking backwards compatibility on main at this point. But we can clean that up in a future PR.

[nbbrooks]

Maybe I am misunderstanding the role of the ABI check jobs. Are they to check if the package is breaking ABI, not if it is compatible with upstream ABI?

But if that is true...then why is Jazzy ABI passing?

[nbbrooks]

OK Humble is failing at abi_build_target and rolling at abi_build_base, I missed that. Jazzy has both APIs which is why it passes.

I'm going to force merge this in, but will need to turn the humble job into a kilted job since main no longer supports humble and we are missing kilted.

[nbbrooks]

Oops, I did not switch this to a squash merge :|