Merge pull request #217 from egonw/fix/noFullName

mkutmon · web-flow · commit 8c418c9c9ed2 · 2025-01-22T20:13:41.000+01:00
[PV3.4] Fixes a exception that blocks closing the property dialog
diff --git a/modules/org.pathvisio.core/src/org/pathvisio/core/model/PathwayElement.java b/modules/org.pathvisio.core/src/org/pathvisio/core/model/PathwayElement.java
@@ -1005,7 +1005,9 @@ public void setStaticProperty(StaticProperty key, Object value)
 			}
 			else
 			{
-				setDataSource(DataSource.getExistingByFullName((String)value));
+				if (DataSource.fullNameExists((String)value)) {
+					setDataSource(DataSource.getExistingByFullName((String)value));
+				}
 			}
 			break;
 		case TYPE:

Original file line number	Diff line number	Diff line change
`@@ -1005,7 +1005,9 @@ public void setStaticProperty(StaticProperty key, Object value)`
`1005`	`1005`	`}`
`1006`	`1006`	`else`
`1007`	`1007`	`{`
`1008`		`- setDataSource(DataSource.getExistingByFullName((String)value));`
	`1008`	`+ if (DataSource.fullNameExists((String)value)) {`
	`1009`	`+ setDataSource(DataSource.getExistingByFullName((String)value));`
	`1010`	`+ }`
`1009`	`1011`	`}`
`1010`	`1012`	`break;`
`1011`	`1013`	`case TYPE:`