Skip to content

Commit 527bad0

Browse files
authored
Use more modern tooling for multi-arch image creation (#5325)
* Use more modern tooling for multi-arch image creation * Logging and last "push" command no longer necessary * PowerShell and backticks (eyeroll)
1 parent 2fbd4f2 commit 527bad0

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/build-db-container.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,15 @@ jobs:
6969
TAG_NAME: ${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.number) || env.MinVerVersion }}
7070
shell: pwsh
7171
run: |
72-
$manifestCreate = "docker manifest create ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}"
72+
Write-Output "Creating multi-arch manifest creation command for containers specified in src/ServiceControl.RavenDB/containers.json"
73+
$manifestCreate = "docker buildx imagetools create -t ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}"
7374
$containers = cat src/ServiceControl.RavenDB/containers.json | ConvertFrom-Json
7475
$containers | ForEach-Object -Process {
75-
$manifestCreate += " --amend ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}-$($_.tag)"
76+
$manifestCreate += " ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}-$($_.tag)"
7677
}
78+
Write-Output "Invoking manifest creation command: > $manifestCreate"
7779
Invoke-Expression $manifestCreate
80+
Write-Output "Multi-arch image should now be on GitHub Container Registry at https://github.com/Particular/ServiceControl/pkgs/container/servicecontrol-ravendb/"
81+
Write-Output "Inspecting resulting tag ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}"
7882
docker buildx imagetools inspect ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}
79-
docker manifest push ghcr.io/particular/servicecontrol-ravendb:${{ env.TAG_NAME }}
83+

0 commit comments

Comments
 (0)