Skip to content

Commit 4e141e0

Browse files
author
Vincent Potucek
committed
Add SanityCheck#EqualityRulesRecipes spring-projects#48630
Signed-off-by: Vincent Potucek <vpotucek@me.com> ``` Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/io/InspectedContent.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/Cache.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/EphemeralBuilderTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtOffsetRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildRequestTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/ImageBuildpackTests.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to cli/spring-boot-cli/src/test/resources/commands/command.groovy by: org.openrewrite.java.format.RemoveTrailingWhitespace Changes have been made to cli/spring-boot-cli/src/test/resources/dir-sample/code/app.groovy by: org.openrewrite.java.format.RemoveTrailingWhitespace Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/closure.groovy by: org.openrewrite.java.format.RemoveTrailingWhitespace Changes have been made to cli/spring-boot-cli/src/test/resources/scripts/command.groovy by: org.openrewrite.java.format.RemoveTrailingWhitespace Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/info/SslInfoTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/logging/AbstractLoggingSystemTests.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodToStringConverterTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/convert/PeriodStyleTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ZeroPeriodRecipe Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/util/TestPropertyValues.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/system/OutputCapture.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/net/protocol/nested/NestedUrlConnection.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe Changes have been made to loader/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/SizeCalculatingEntryWriter.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/web/exchanges/HttpExchange.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/management/HeapDumpWebEndpoint.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/info/InfoPropertiesInfoContributor.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to module/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/invoker/cache/CachingOperationInvoker.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to module/spring-boot-devtools/src/main/java/org/springframework/boot/devtools/filewatch/ChangedFile.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to module/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/MainMethodTests.java by: org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference Changes have been made to module/spring-boot-jetty/src/main/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizer.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to module/spring-boot-jetty/src/test/java/org/springframework/boot/jetty/autoconfigure/JettyWebServerFactoryCustomizerTests.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$FilesCreateTempFileToFileRecipe Changes have been made to module/spring-boot-kafka/src/main/java/org/springframework/boot/kafka/autoconfigure/ConcurrentKafkaListenerContainerFactoryConfigurer.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe Changes have been made to module/spring-boot-micrometer-metrics/src/main/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinder.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$ClockInstantRecipe Changes have been made to module/spring-boot-micrometer-metrics/src/test/java/org/springframework/boot/micrometer/metrics/autoconfigure/ssl/SslMeterBinderTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe Changes have been made to module/spring-boot-security/src/test/java/org/springframework/boot/security/autoconfigure/UserDetailsServiceAutoConfigurationTests.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe Changes have been made to module/spring-boot-sql/src/main/java/org/springframework/boot/sql/autoconfigure/init/OnDatabaseInitializationCondition.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityRecipe tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$NegationRecipe Changes have been made to module/spring-boot-tomcat/src/test/java/org/springframework/boot/tomcat/servlet/TomcatServletWebServerFactoryTests.java by: org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference Changes have been made to module/spring-boot-webflux/src/test/java/org/springframework/boot/webflux/observation/autoconfigure/WebFluxObservationAutoConfigurationTests.java by: tech.picnic.errorprone.refasterrules.TimeRulesRecipes tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfSecondsRecipe Changes have been made to module/spring-boot-zipkin/src/main/java/org/springframework/boot/zipkin/autoconfigure/ZipkinHttpClientSender.java by: org.openrewrite.staticanalysis.ReplaceLambdaWithMethodReference Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by: tech.picnic.errorprone.refasterrules.FileRulesRecipes tech.picnic.errorprone.refasterrules.FileRulesRecipes$PathOfUriRecipe Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/system/OutputCapture.java by: tech.picnic.errorprone.refasterrules.EqualityRulesRecipes tech.picnic.errorprone.refasterrules.EqualityRulesRecipes$EnumReferenceEqualityLambdaRecipe Please review and commit the results. Estimate time saved: 3h 6m BUILD SUCCESSFUL in 18m 9s ```
1 parent 927b2ee commit 4e141e0

51 files changed

Lines changed: 192 additions & 90 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/actions/build/action.yml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build
1+
name: Build 📦
22
description: 'Builds the project, optionally publishing it to a local deployment repository'
33
inputs:
44
commercial-release-repository-url:
@@ -50,7 +50,7 @@ outputs:
5050
runs:
5151
using: composite
5252
steps:
53-
- name: Prepare Gradle Build
53+
- name: Prepare Gradle Build ⚙️
5454
uses: ./.github/actions/prepare-gradle-build
5555
with:
5656
cache-read-only: ${{ inputs.gradle-cache-read-only }}
@@ -59,7 +59,7 @@ runs:
5959
java-early-access: ${{ inputs.java-early-access }}
6060
java-toolchain: ${{ inputs.java-toolchain }}
6161
java-version: ${{ inputs.java-version }}
62-
- name: Build
62+
- name: Sanity Build 📦
6363
id: build
6464
if: ${{ inputs.publish == 'false' }}
6565
shell: bash
@@ -68,8 +68,19 @@ runs:
6868
COMMERCIAL_REPO_PASSWORD: ${{ inputs.commercial-repository-password }}
6969
COMMERCIAL_REPO_USERNAME: ${{ inputs.commercial-repository-username }}
7070
COMMERCIAL_SNAPSHOT_REPO_URL: ${{ inputs.commercial-snapshot-repository-url }}
71-
run: ./gradlew build
72-
- name: Publish
71+
# run: ./gradlew build
72+
run: ./gradlew rewriteDryRun build -Dorg.gradle.jvmargs=-Xmx12G
73+
- name: Sanity Check 🦢
74+
id: sanity
75+
if: ${{ inputs.publish == 'false' }}
76+
shell: bash
77+
env:
78+
COMMERCIAL_RELEASE_REPO_URL: ${{ inputs.commercial-release-repository-url }}
79+
COMMERCIAL_REPO_PASSWORD: ${{ inputs.commercial-repository-password }}
80+
COMMERCIAL_REPO_USERNAME: ${{ inputs.commercial-repository-username }}
81+
COMMERCIAL_SNAPSHOT_REPO_URL: ${{ inputs.commercial-snapshot-repository-url }}
82+
run: ./gradlew rewriteDryRun -Dorg.gradle.jvmargs=-Xmx12G
83+
- name: Publish 📡
7384
id: publish
7485
if: ${{ inputs.publish == 'true' }}
7586
shell: bash

.github/workflows/build-and-deploy-snapshot.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
if: ${{ github.repository == 'spring-projects/spring-boot' || github.repository == 'spring-projects/spring-boot-commercial' }}
1515
runs-on: ${{ vars.UBUNTU_MEDIUM || 'ubuntu-latest' }}
1616
steps:
17-
- name: Check Out Code
17+
- name: Checkout Code 📥
1818
uses: actions/checkout@v6
19-
- name: Build and Publish
19+
- name: Build 📦 and Publish 📡
2020
id: build-and-publish
2121
uses: ./.github/actions/build
2222
with:
Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,27 @@
1-
name: Build Pull Request
1+
name: Build Pull Request 🏭️
22
on: pull_request
33
permissions:
44
contents: read
55
jobs:
66
build:
7-
name: Build Pull Request
7+
name: Build 📦
88
if: ${{ github.repository == 'spring-projects/spring-boot' }}
99
runs-on: ${{ vars.UBUNTU_MEDIUM || 'ubuntu-latest' }}
1010
steps:
11-
- name: Check Out Code
11+
- name: Checkout Code 📥
1212
uses: actions/checkout@v6
13-
- name: Build
13+
- name: Build 📦
1414
id: build
1515
uses: ./.github/actions/build
16-
- name: Print JVM Thread Dumps When Cancelled
16+
- name: Log Potentially Canceled JVM Thread Dumps 📋
1717
if: cancelled()
1818
uses: ./.github/actions/print-jvm-thread-dumps
19-
- name: Upload Build Reports
19+
- name: Upload Build Report 📊
2020
if: failure()
2121
uses: actions/upload-artifact@v6
2222
with:
2323
name: build-reports
2424
path: '**/build/reports/'
25+
- name: Sanity 🕊️
26+
id: sanity
27+
uses: ./.github/actions/build

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ jobs:
3939
git config --global core.autocrlf true
4040
git config --global core.longPaths true
4141
Stop-Service -name Docker
42-
- name: Check Out Code
42+
- name: Checkout Code 📥
4343
uses: actions/checkout@v6
44-
- name: Build
44+
- name: Build 📦
4545
id: build
4646
uses: ./.github/actions/build
4747
with:

.github/workflows/distribute.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ permissions:
1919
contents: read
2020
jobs:
2121
distribute-spring-enterprise-release-bundle:
22+
name: Distribute Release Bundle 📦
2223
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
2324
steps:
2425
- name: Create Bundle

.github/workflows/release-milestone.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
if: ${{ github.repository == 'spring-projects/spring-boot' }}
1515
runs-on: ${{ vars.UBUNTU_MEDIUM || 'ubuntu-latest' }}
1616
steps:
17-
- name: Check Out Code
17+
- name: Checkout Code 📥
1818
uses: actions/checkout@v6
19-
- name: Build and Publish
19+
- name: Build 📦 and Publish 📡
2020
id: build-and-publish
2121
uses: ./.github/actions/build
2222
with:
@@ -59,7 +59,7 @@ jobs:
5959
- verify
6060
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
6161
steps:
62-
- name: Check Out Code
62+
- name: Checkout Code 📥
6363
uses: actions/checkout@v6
6464
- name: Sync to Maven Central
6565
uses: ./.github/actions/sync-to-maven-central
@@ -89,7 +89,7 @@ jobs:
8989
- sync-to-maven-central
9090
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
9191
steps:
92-
- name: Check Out Code
92+
- name: Checkout Code 📥
9393
uses: actions/checkout@v6
9494
- name: Publish
9595
uses: ./.github/actions/publish-gradle-plugin
@@ -120,7 +120,7 @@ jobs:
120120
- trigger-docs-build
121121
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
122122
steps:
123-
- name: Check Out Code
123+
- name: Checkout Code 📥
124124
uses: actions/checkout@v6
125125
- name: Create GitHub Release
126126
uses: ./.github/actions/create-github-release

.github/workflows/release.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ jobs:
1313
if: ${{ github.repository == 'spring-projects/spring-boot' || github.repository == 'spring-projects/spring-boot-commercial' }}
1414
runs-on: ${{ vars.UBUNTU_MEDIUM || 'ubuntu-latest' }}
1515
steps:
16-
- name: Check Out Code
16+
- name: Checkout Code 📥
1717
uses: actions/checkout@v6
18-
- name: Build and Publish
18+
- name: Build 📦 and Publish 📡
1919
id: build-and-publish
2020
uses: ./.github/actions/build
2121
with:
@@ -70,7 +70,7 @@ jobs:
7070
- verify
7171
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
7272
steps:
73-
- name: Check Out Code
73+
- name: Checkout Code 📥
7474
uses: actions/checkout@v6
7575
- name: Sync to Maven Central
7676
uses: ./.github/actions/sync-to-maven-central
@@ -104,7 +104,7 @@ jobs:
104104
- sync-to-maven-central
105105
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
106106
steps:
107-
- name: Check Out Code
107+
- name: Checkout Code 📥
108108
uses: actions/checkout@v6
109109
- name: Publish
110110
uses: ./.github/actions/publish-gradle-plugin
@@ -121,7 +121,7 @@ jobs:
121121
- sync-to-maven-central
122122
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
123123
steps:
124-
- name: Check Out Code
124+
- name: Checkout Code 📥
125125
uses: actions/checkout@v6
126126
- name: Publish to SDKMAN!
127127
uses: ./.github/actions/publish-to-sdkman
@@ -137,7 +137,7 @@ jobs:
137137
- sync-to-maven-central
138138
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
139139
steps:
140-
- name: Check Out Code
140+
- name: Checkout Code 📥
141141
uses: actions/checkout@v6
142142
- name: Update Homebrew Tap
143143
uses: ./.github/actions/update-homebrew-tap
@@ -168,7 +168,7 @@ jobs:
168168
- update-homebrew-tap
169169
runs-on: ${{ vars.UBUNTU_SMALL || 'ubuntu-latest' }}
170170
steps:
171-
- name: Check Out Code
171+
- name: Checkout Code 📥
172172
uses: actions/checkout@v6
173173
- name: Create GitHub Release
174174
uses: ./.github/actions/create-github-release

.github/workflows/run-codeql-analysis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
name: "Run CodeQL Analysis"
1+
name: Run CodeQL Analysis 📊
22
on:
33
push:
44
pull_request:
55
workflow_dispatch:
66
permissions: read-all
77
jobs:
88
run-analysis:
9+
name: Inspect 🔎
910
permissions:
1011
actions: read
1112
contents: read

.github/workflows/run-system-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- version: 21
1919
toolchain: true
2020
steps:
21-
- name: Check Out Code
21+
- name: Checkout Code 📥
2222
uses: actions/checkout@v6
2323
- name: Prepare Gradle Build
2424
uses: ./.github/actions/prepare-gradle-build

build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.nio.charset.UnsupportedCharsetException;
2525
import java.nio.file.Files;
2626
import java.nio.file.Path;
27-
import java.nio.file.Paths;
2827
import java.util.Arrays;
2928
import java.util.Collections;
3029
import java.util.List;
@@ -139,7 +138,7 @@ private static boolean isWindows(UnaryOperator<@Nullable String> getSystemProper
139138

140139
private static String toPathString(URL url) {
141140
try {
142-
return Paths.get(url.toURI()).toString();
141+
return Path.of(url.toURI()).toString();
143142
}
144143
catch (URISyntaxException ex) {
145144
throw new IllegalArgumentException(ex);

0 commit comments

Comments
 (0)