Skip to content

Commit 2061ecd

Browse files
Scope issue and PR references to local vs remote repositories
1 parent 98d3ab6 commit 2061ecd

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/docs/Ways-of-Working/Commit-Conventions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Commit messages serve two audiences: the engineer reading `git log` six months f
88
2. **No conventional-commit prefixes.** No `fix:`, `feat:`, `docs:`, `chore:`, `refactor:`, etc. The change type is captured at the PR level — repeating it on every commit adds noise without information.
99
3. **No generic messages.** `Update for PR`, `WIP`, `fixes`, `more changes` — all forbidden. They erase traceability.
1010
4. **One logical change per commit.** Micro-iterative discipline. If a change touches three unrelated concerns, that's three commits.
11-
5. **Reference issues with the fully qualified `Owner/Repo#N` form when natural** — but don't force it. A closing keyword such as `Fixes Owner/Repo#N` belongs in the PR description, not every commit message. Avoid the bare `#N` shorthand so references stay unambiguous across repositories.
11+
5. **Reference issues scoped to their target when natural**the `#123` shorthand for the same repository, the fully qualified `Owner/Repo#123` form for another repository. Don't force it; a closing keyword such as `Fixes #123` belongs in the PR description, not every commit message.
1212

1313
## Examples
1414

src/docs/Ways-of-Working/Issue-Format.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Every issue in the PSModule organization follows the same structure. The format
1313
- **Comments record change history only.** Each description update is accompanied by a comment summarizing what changed and why.
1414
- **Tone is impersonal.** No first-person ("I", "my") or second-person ("you", "your") language. Neutral references like "the user", "the developer", or passive constructions.
1515
- **External references are hyperlinks.** Every mention of an API, RFC, library, doc, or tool is a clickable `[text](url)` link. No bare URLs.
16-
- **Issue and PR references are fully qualified.** Cross-reference other issues and pull requests with `Owner/Repo#N` (for example `PSModule/GitHub#123`), never the bare `#123` shorthand, so links resolve unambiguously across repositories and in release notes. Outside GitHub — Jira, Confluence, Slack, or any surface without GitHub autolinking — use the full URL (`https://github.com/PSModule/GitHub/issues/123`).
16+
- **Issue and PR references are scoped to their target.** Use the `#123` shorthand for an issue or pull request in the same repository, and the fully qualified `Owner/Repo#123` form for one in another repository so the link resolves to the right place. Outside GitHub — Jira, Confluence, Slack, or any surface without GitHub autolinking — use the full URL (`https://github.com/Owner/Repo/issues/123`).
1717
- **No duplicates.** Existing issues are searched before creating or restructuring. Duplicates are consolidated or cross-linked.
1818

1919
## Title

src/docs/Ways-of-Working/PR-Format.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ Omit the section entirely if there's nothing noteworthy.
103103

104104
### 4. Related issues
105105

106-
A collapsible `<details>` block at the very end of the description containing issue links. Always use fully qualified references (`Owner/Repo#N`, for example `PSModule/GitHub#123`) — never the bare `#123` shorthand — so links resolve unambiguously across repositories and in release notes. When a reference appears outside GitHub (release announcements, Jira, Slack, external docs), use the full URL (`https://github.com/PSModule/GitHub/issues/123`).
106+
A collapsible `<details>` block at the very end of the description containing issue links. Use the `#123` shorthand for issues in the same repository and the fully qualified `Owner/Repo#123` form for issues in another repository so links resolve to the right place. When a reference appears outside GitHub (release announcements, Jira, Slack, external docs), use the full URL (`https://github.com/Owner/Repo/issues/123`).
107107

108108
```markdown
109109
<details>
110110
<summary>Related issues</summary>
111111

112-
- Fixes PSModule/GitHub#123
112+
- Fixes #123
113113
- PSModule/Process-PSModule#124
114114

115115
</details>
@@ -150,13 +150,13 @@ Commands that query a specific repository, enterprise, or release by name now re
150150
- `GitHubRepository` class: `CustomProperties` property changed from `[PSCustomObject]` to `[GitHubCustomProperty[]]`.
151151
- `Invoke-GitHubGraphQLQuery`: error handling split into partial-success (data + errors → warnings) and full-failure (errors only → terminating error) branches.
152152
- Null guards added to `Get-GitHubRepositoryByName`, `Get-GitHubMyRepositoryByName`, and related functions.
153-
- Implementation plan progress: tasks 1–3 in PSModule/GitHub#218 completed; task 4 (integration tests) remains.
153+
- Implementation plan progress: tasks 1–3 in #218 completed; task 4 (integration tests) remains.
154154

155155
<details>
156156
<summary>Related issues</summary>
157157

158-
- Fixes PSModule/GitHub#218
159-
- PSModule/GitHub#219
158+
- Fixes #218
159+
- #219
160160

161161
</details>
162162
````

0 commit comments

Comments
 (0)