Skip to content

Commit cccfc40

Browse files
authored
Merge pull request #122 from PSMRI/Sn/3.6.2
fix: prevent user logout on sub store indent receive error
2 parents 607563b + 16d600d commit cccfc40

6 files changed

Lines changed: 27 additions & 21 deletions

File tree

src/app/app-modules/core/services/http-interceptor.service.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,13 @@ export class HttpInterceptorService implements HttpInterceptor {
8181

8282
if (error.status === 401 || error.status === 403) {
8383
this.confirmationService.alert(
84-
"Session expired. Please log in again to continue", 'error'
84+
'Session expired. Please log in again to continue',
85+
'error',
8586
);
86-
} else this.confirmationService.alert(
87-
error.error.errorMessage || "Something went wrong. Please try again later.",
88-
'error',
89-
);
90-
this.router.navigate(['/login']);
91-
sessionStorage.clear();
92-
localStorage.clear();
87+
this.router.navigate(['/login']);
88+
sessionStorage.clear();
89+
localStorage.clear();
90+
}
9391
this.spinnerService.show();
9492
return throwError(error.error);
9593
}),

src/app/app-modules/inventory/indent/indent-order-worklist/sub-store-indent-order-worklist/sub-store-indent-order-worklist.component.ts

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -114,17 +114,25 @@ export class SubStoreIndentOrderWorklistComponent implements OnInit, DoCheck {
114114
console.log('acceptorder', acceptorder);
115115
this.inventoryService
116116
.receiveIndentOrder(acceptorder)
117-
.subscribe((acceptOrderResponse) => {
118-
if (acceptOrderResponse.statusCode === 200) {
117+
.subscribe(
118+
(acceptOrderResponse) => {
119+
if (acceptOrderResponse.statusCode === 200) {
120+
this.confirmationService.alert(
121+
acceptOrderResponse.data.response,
122+
'success',
123+
);
124+
this.showSubstoreOrderWorklist(this.orderReqObject);
125+
} else {
126+
this.confirmationService.alert(acceptOrderResponse.errorMessage);
127+
}
128+
},
129+
(error) => {
130+
console.error('Error receiving indent', error);
119131
this.confirmationService.alert(
120-
acceptOrderResponse.data.response,
121-
'success',
132+
error?.errorMessage || this.currentLanguageSet?.inventory?.receiveIndentFailed || 'Failed to receive indent. Please try again.',
122133
);
123-
this.showSubstoreOrderWorklist(this.orderReqObject);
124-
} else {
125-
this.confirmationService.alert(acceptOrderResponse.errorMessage);
126-
}
127-
});
134+
},
135+
);
128136
}
129137
goToUpdateIndentRequest(indentDetails: any) {
130138
console.log('indentDetails', indentDetails);

src/environments/environment.ci.ts.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const environment = {
115115
viewItemListForMainStoreUrl: `${INVENTORY_API}indentController/getIndentOrderWorklist`,
116116

117117
getSaveDispenseListUrl: `${INVENTORY_API}indentController/issueIndent`,
118-
receiveIndentOrderUrl: `${INVENTORY_API}/indentController/receiveIndent`,
118+
receiveIndentOrderUrl: `${INVENTORY_API}indentController/receiveIndent`,
119119
updateIndentOrderUrl: `${INVENTORY_API}indentController/updateIndentOrder`,
120120

121121
/* Report URL's*/

src/environments/environment.local.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export const environment = {
124124
viewItemListForMainStoreUrl: `${INVENTORY_API}indentController/getIndentOrderWorklist`,
125125

126126
getSaveDispenseListUrl: `${INVENTORY_API}indentController/issueIndent`,
127-
receiveIndentOrderUrl: `${INVENTORY_API}/indentController/receiveIndent`,
127+
receiveIndentOrderUrl: `${INVENTORY_API}indentController/receiveIndent`,
128128
updateIndentOrderUrl: `${INVENTORY_API}indentController/updateIndentOrder`,
129129

130130
/* Report URL's*/

src/environments/environment.prod.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export const environment = {
125125
viewItemListForMainStoreUrl: `${INVENTORY_API}indentController/getIndentOrderWorklist`,
126126

127127
getSaveDispenseListUrl: `${INVENTORY_API}indentController/issueIndent`,
128-
receiveIndentOrderUrl: `${INVENTORY_API}/indentController/receiveIndent`,
128+
receiveIndentOrderUrl: `${INVENTORY_API}indentController/receiveIndent`,
129129
updateIndentOrderUrl: `${INVENTORY_API}indentController/updateIndentOrder`,
130130

131131
/* Report URL's*/

src/environments/environment.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export const environment = {
119119
viewItemListForMainStoreUrl: `${INVENTORY_API}indentController/getIndentOrderWorklist`,
120120

121121
getSaveDispenseListUrl: `${INVENTORY_API}indentController/issueIndent`,
122-
receiveIndentOrderUrl: `${INVENTORY_API}/indentController/receiveIndent`,
122+
receiveIndentOrderUrl: `${INVENTORY_API}indentController/receiveIndent`,
123123
updateIndentOrderUrl: `${INVENTORY_API}indentController/updateIndentOrder`,
124124

125125
/* Report URL's*/

0 commit comments

Comments
 (0)