From 0ef7441e09b519a0df7cd5d9f4f944608b5c24d8 Mon Sep 17 00:00:00 2001 From: Vest Date: Thu, 25 Jun 2026 21:38:06 +0200 Subject: [PATCH] CDOM: mark CNAbility + CNAbilitySelection final (CT_CONSTRUCTOR_THROW) Same shape as PR #7627, which marked 20 leaf classes final to silence SpotBugs CT_CONSTRUCTOR_THROW. These two classes escaped that PR's net. Verified via grep that no subclasses exist in code/src/{java,test,itest,slowtest}; the only matches for "extends CNAbility" / "extends CNAbilitySelection" are `` generic wildcards, not class inheritance. SpotBugs XML delta confirms exactly 3 CT_CONSTRUCTOR_THROW findings cleared (CNAbility one constructor, CNAbilitySelection two constructors), 0 new findings. --- code/src/java/pcgen/cdom/content/CNAbility.java | 2 +- code/src/java/pcgen/cdom/helper/CNAbilitySelection.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/code/src/java/pcgen/cdom/content/CNAbility.java b/code/src/java/pcgen/cdom/content/CNAbility.java index bc7ff290d3e..a083b6b9604 100644 --- a/code/src/java/pcgen/cdom/content/CNAbility.java +++ b/code/src/java/pcgen/cdom/content/CNAbility.java @@ -38,7 +38,7 @@ /** * An CNAbility represents an "unresolved" (categorized) Ability & Nature. */ -public class CNAbility extends ConcretePrereqObject +public final class CNAbility extends ConcretePrereqObject implements QualifyingObject, Comparable, ChooseDriver, Reducible { diff --git a/code/src/java/pcgen/cdom/helper/CNAbilitySelection.java b/code/src/java/pcgen/cdom/helper/CNAbilitySelection.java index 654f06d5fc5..141df8191db 100644 --- a/code/src/java/pcgen/cdom/helper/CNAbilitySelection.java +++ b/code/src/java/pcgen/cdom/helper/CNAbilitySelection.java @@ -33,7 +33,7 @@ import pcgen.core.SettingsHandler; import pcgen.rules.context.LoadContext; -public class CNAbilitySelection extends ConcretePrereqObject implements QualifyingObject, Reducible +public final class CNAbilitySelection extends ConcretePrereqObject implements QualifyingObject, Reducible { private final CNAbility cna;