i18n: refactor browserLanguagesToLang to use navigator.languages directly

Author: Jaehyuk-Lee

resources/languages.ts

@@ -89,8 +89,7 @@ export const langToLocale = (lang: Lang): string => {
   }[lang];
 };
 
-export const browserLanguagesToLang = (languagesArr: readonly string[]): Lang => {
-  // languagesArr receives only `navigator.languages` as input
+export const browserLanguagesToLang = (): Lang => {
   const mapLanguage = (lang: string): string => {
     // Handle Chinese variants
     if (lang.startsWith('zh-')) {
@@ -107,7 +106,7 @@ export const browserLanguagesToLang = (languagesArr: readonly string[]): Lang =>
     }
     return lang.slice(0, 2);
   };
-  const lang = [...languagesArr, 'en']
+  const lang = [...navigator.languages, 'en']
     .map(mapLanguage)
     .filter((l) => languages.includes(l as Lang))[0];
   return isLang(lang) ? lang : 'en';

ui/raidboss/raidemulator.ts

@@ -151,7 +151,7 @@ const raidEmulatorOnLoad = async () => {
 
   if (!websocketConnected) {
     // Find the most appropriate lang code to use based on browser language priority
-    const browserLang = browserLanguagesToLang(navigator.languages);
+    const browserLang = browserLanguagesToLang();
     applyTranslation(browserLang);
 
     options.ParserLanguage = browserLang;

util/coverage/coverage.ts

@@ -1363,7 +1363,7 @@ const buildLanguageSelect = (container: HTMLElement, lang: Lang) => {
 document.addEventListener('DOMContentLoaded', () => {
   // Allow for `coverage.html?lang=de` style constructions.
   const params = new URLSearchParams(window.location.search);
-  const langStr = params.get('lang') ?? browserLanguagesToLang(navigator.languages);
+  const langStr = params.get('lang') ?? browserLanguagesToLang();
   // TODO: left for now as backwards compatibility with user css.  Remove this later??
   document.body.classList.add(`lang-${langStr}`);
   const lang = langStr !== null && isLang(langStr) ? langStr : 'en';

util/logtools/web_splitter.ts

@@ -349,7 +349,7 @@ const downloadFile = (output: string[], filename: string): void => {
 };
 
 const onLoaded = () => {
-  const lang = browserLanguagesToLang(navigator.languages);
+  const lang = browserLanguagesToLang();
 
   const table = getElement('fight-table');
   const fileDrop = getElement('filedrop');