Upgrade from OrchardCore 2.1.7 to 2.2.1 and seeing an issue with returning ContentList

[anthnyg12b-hub]

Hi All,

I am working on upgrading from OrchardCore 2.1.7 to 2.2.1 and now I'm seeing an issue with one of our contentItems not returning it's associated list. The table [dbo].[Cms_ContainedPartIndex] has four rows where ListContentItemId is equal to Cms_ContentItemIndex]. I see these items on my version of 2.1.7 but not 2.2.1.

Not sure if this has anything to be do with it but I checked the source code and did notice these changes to the ListQueryHelper.cs class.

[github-actions]

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

If you like Orchard Core, please star our repo and join our community channels.

[agiordano79]

update, we did a trace of the application and it looks like a null parameter is being passed for action method OrchardCore.Contents.Controllers.ItemController.Display (OrchardCore.Contents)

[gvkries]

Can you please share more information, e.g. your templates and if possible some reproduction steps. It seems unlikely, that the mentioned commit causes an issue.

Additionally, the null parameter for ItemController.Display() is legit, it's the optional JSON path, IIRC.

[sebastienros]

Maybe the OrderBy is making the query filter out the records without an Order or Id value? I don't think it;s SQL but maybe YesSql.

@agiordano79 ideally if you could run the source with this commit, and replace these lines to confirm that this is the issue that would help.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[gvkries]

Maybe the OrderBy is making the query filter out the records without an Order or Id value? I don't think it;s SQL but maybe YesSql.

@agiordano79 ideally if you could run the source with this commit, and replace these lines to confirm that this is the issue that would help.

Order is an integer and defaults to 0, and Id is the MapIndex.Id. I don't see how this causes issues.

[gvkries]

And e.g. using {{ Model.ContentItem | list_items | json }} in a template for a blog works fine, even though the blog recipe doesn't use list ordering.

[agiordano79]

Thanks for the feedback, we will investigate this and let you know.

[agiordano79]

I've gone ahead and downloaded/debugged the source code for OrchardCore.Lists and OrchardCore.Contents of version 2.2.1. In OrchardCore.Contents\Controllers\ItemController.cs I've steped through the Display method and found ((dynamic)model).Content.Items[2].ContentItems contains the json of the list items I want to display and ((dynamic)model).ContentItem) to contain basic ContentItem properties. I've also looked at the OrchardCore.Lists\Drivers\ListPartDisplayDriver.cs InitializeDisplayListPartDetailAdminShape method and found model.ContentItems has the expected list after QueryContainedItemsAsync is called. I've compared this to what version 2.1.7 is returning and it matches so the backend code appears to be working correctly. I'm starting to think this may be related to how the model binds to the view in 2.2.1 is the same backend data displayed differently by version? Version 2.1.7 displays the list and json representing courses while 2.2.1 does not. Where there any updates to the binding/view logic?

ControllersItemController_dynamic_model_ContentItem.txt

[gvkries]

IIRC, there were some changes related to the casing in Liquid templates. Not sure which versions are affected, but it's worth to check for that in your templates.

[anthnyg12b-hub]

can you point me in the direction of where this code would be? I'm assuming it's part of the OrchardCMS source code? What nuget package/module or file? I can then compare version 2.1.7 to 2.2.1

[gvkries]

I thought of #17454, but is has been fixed. So it's unlikely. Please share the whole template you're using.