Forward NodeTools types#753
Open
wvpm wants to merge 11 commits into
Open
Conversation
wvpm
force-pushed
the
forward_nodetools_types
branch
6 times, most recently
from
e76cd25 to
2e96e15
Compare
…fiersum Minimise allocations for ModifierSum
Paralellise update gamestate & modifiers
wvpm
force-pushed
the
forward_nodetools_types
branch
from
2e96e15 to
6274046
Compare
wvpm
force-pushed
the
forward_nodetools_types
branch
2 times, most recently
from
271eb78 to
3c60608
Compare
Contributor
Author
|
Please let me know if you have any feedback on this. |
wvpm
force-pushed
the
forward_nodetools_types
branch
from
3c60608 to
0e8f274
Compare
wvpm
force-pushed
the
forward_nodetools_types
branch
from
0e8f274 to
d130288
Compare
Member
|
This PR is doing way too much, if you want to split things off into their own files you should be trying to make atomic PRs splitting them off for one. |
wvpm
force-pushed
the
dev
branch
2 times, most recently
from
429d310 to
5951491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeTools.hpp is only required for parsing methods. All callbacks and such should use forwarded types instead.