Skip to content

Commit 8a02494

Browse files
hhvrcclaude
andcommitted
fix: resolve build errors in serial command handlers
- Add const qualifier to CommandEntry::commandHandler() - Explicit std::string conversion in hostname handleSet - Use push_back instead of append for single char in validgpios Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d0a95dd commit 8a02494

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

include/serial/command_handlers/CommandEntry.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace OpenShock::Serial {
1515
inline std::string_view name() const { return m_name; }
1616
inline std::string_view description() const { return m_description; }
1717
inline const std::vector<CommandArgument>& arguments() const { return m_arguments; }
18-
inline CommandHandler commandHandler() { return m_commandHandler; }
18+
inline CommandHandler commandHandler() const { return m_commandHandler; }
1919

2020
CommandArgument& addArgument(std::string_view name, std::string_view constraint, std::string_view exampleValue, std::vector<std::string_view> constraintExtensions = {});
2121

src/serial/command_handlers/hostname.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ static void handleGet(std::string_view arg, bool isAutomated)
2727

2828
static void handleSet(std::string_view arg, bool isAutomated)
2929
{
30-
bool result = OpenShock::Config::SetWiFiHostname(arg);
30+
bool result = OpenShock::Config::SetWiFiHostname(std::string(arg));
3131
if (result) {
3232
SERPR_SUCCESS("Saved config, restarting...");
3333
esp_restart();

src/serial/command_handlers/validgpios.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ static void handleValidGpios(std::string_view arg, bool isAutomated)
2020
for (std::size_t i = 0; i < pins.size(); i++) {
2121
if (pins[i]) {
2222
buffer.append(std::to_string(i));
23-
buffer.append(',');
23+
buffer.push_back(',');
2424
}
2525
}
2626

0 commit comments

Comments
 (0)