Merge branch 'develop' into feature/improve-led-managers

Author: hhvrc

.github/actions/build-compilationdb/action.yml

@@ -0,0 +1,42 @@
+name: build-compilationdb
+description: Builds the compilation database for the firmware for code analysis
+inputs:
+  version:
+    required: true
+    description: 'Current firmware version'
+  skip-checkout:
+    description: 'If true, skips checkout'
+    required: false
+    default: false
+
+runs:
+  using: composite
+  steps:
+    - uses: actions/checkout@v4
+      if: ${{ !inputs.skip-checkout }}
+
+    - uses: actions/cache@v4
+      with:
+        path: |
+          ~/.platformio/platforms
+          ~/.platformio/packages
+          ~/.platformio/.cache
+        key: pio-${{ runner.os }}-${{ hashFiles('platformio.ini', 'requirements.txt') }}
+
+    - uses: actions/setup-python@v5
+      with:
+        cache: 'pip'
+
+    - name: Install python dependencies
+      shell: bash
+      run: pip install -r requirements.txt
+
+    - name: Build firmware
+      working-directory: .
+      shell: bash
+      run: pio run -e ci-build -t compiledb
+      env:
+        OPENSHOCK_FW_VERSION: ${{ inputs.version }}
+        OPENSHOCK_FW_GIT_REF: ${{ github.ref }}
+        OPENSHOCK_FW_GIT_COMMIT: ${{ github.sha }}
+        OPENSHOCK_FW_BUILD_DATE: ${{ github.event.head_commit.timestamp }}

.github/scripts/get-vars.js

@@ -201,9 +201,9 @@ if (versionChangeLog !== '') {
 // Parse platformio.ini and extract the different boards
 const platformioIni = ini.parse(platformioIniStr);
 
-// Get every key that starts with "env:", and that isnt "env:fs" (which is the filesystem)
+// Get every key that starts with "env:", and that isnt "env:fs" (which is the filesystem) or "env:ci-build" (which is for CI CodeQL and cppcheck)
 const boards = Object.keys(platformioIni)
-  .filter((key) => key.startsWith('env:') && key !== 'env:fs')
+  .filter((key) => key.startsWith('env:') && key !== 'env:fs' && key !== 'env:ci-build')
   .reduce((arr, key) => {
     arr.push(key.substring(4));
     return arr;

.github/workflows/codeql.yml

@@ -70,11 +70,6 @@ jobs:
       language: 'c-cpp'
       OPENSHOCK_FW_VERSION: ${{ needs.get-vars.outputs.version }}
 
-    strategy:
-      fail-fast: false
-      matrix:
-        board: ${{ fromJson(needs.get-vars.outputs.board-array) }}
-
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -86,7 +81,7 @@ jobs:
 
       - uses: ./.github/actions/build-firmware
         with:
-          board: ${{ matrix.board }}
+          board: ci-build
           skip-checkout: true
 
       - name: Perform CodeQL Analysis

.github/workflows/cpp-linter.yml

@@ -9,13 +9,27 @@ on:
   workflow_dispatch: # Manually invoked by user.
 
 jobs:
+  get-vars:
+    uses: ./.github/workflows/get-vars.yml
+
   cpp-linter:
+    name: C/C++ Linter
     runs-on: ubuntu-latest
+    needs: get-vars
+
     permissions:
-      contents: read
+      contents: write
       pull-requests: write
+    
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - uses: ./.github/actions/build-compilationdb
+        with:
+          board: OpenShock-Core-V2 # Doesn't matter, just need the compilation database
+          skip-checkout: true
+      
       - uses: cpp-linter/cpp-linter-action@v2
         id: linter
         env:

.gitignore

@@ -17,3 +17,4 @@ data/www
 .vs
 packages
 *.sln
+compile_commands.json