Fix compilation error and stop using DEBUG macro where applicable

Author: hhvrc

Common/Extensions/ConfigurationExtensions.cs

@@ -7,9 +7,11 @@ public static class ConfigurationExtensions
 {
     public static WebApplicationBuilder RegisterCommonOpenShockOptions(this WebApplicationBuilder builder)
     {
-#if DEBUG
-        Console.WriteLine(builder.Configuration.GetDebugView());
-#endif
+        if (builder.Environment.IsDevelopment())
+        {
+            Console.WriteLine(builder.Configuration.GetDebugView());
+        }
+        
         builder.Services.Configure<DatabaseOptions>(builder.Configuration.GetRequiredSection(DatabaseOptions.SectionName));
         builder.Services.AddSingleton<IValidateOptions<DatabaseOptions>, DatabaseOptionsValidator>();
 

Cron/Program.cs

@@ -2,6 +2,7 @@
 using Hangfire.PostgreSql;
 using OpenShock.Common;
 using OpenShock.Common.Extensions;
+using OpenShock.Cron;
 using OpenShock.Cron.Utils;
 
 var builder = OpenShockApplication.CreateDefaultBuilder<Program>(args);
@@ -22,15 +23,13 @@
 
 app.UseCommonOpenShockMiddleware();
 
-app.UseHangfireDashboard(options: new DashboardOptions
+var hangfireOptions = new DashboardOptions();
+if (app.Environment.IsProduction())
 {
-#if !DEBUG
-    AsyncAuthorization =
-    [
-        new DashboardAdminAuth()
-    ]
-#endif
-});
+    hangfireOptions.AsyncAuthorization = [ new DashboardAdminAuth() ];
+}
+
+app.UseHangfireDashboard(options: hangfireOptions);
 
 var jobManager = app.Services.GetRequiredService<IRecurringJobManagerV2>();
 foreach (var cronJob in CronJobCollector.GetAllCronJobs())