More endpoint cleanup

Author: hhvrc

API/Controller/Account/Signup.cs

@@ -27,7 +27,6 @@ public async Task<IActionResult> SignUp([FromBody] SignUp body)
         var creationAction = await _accountService.CreateAccount(body.Email, body.Username, body.Password);
         if (creationAction.IsT1) return Problem(SignupError.EmailAlreadyExists);
 
-
         return LegacyEmptyOk("Successfully signed up");
     }
 }

API/Controller/Account/_ApiController.cs

@@ -13,8 +13,7 @@ namespace OpenShock.API.Controller.Account;
 /// </summary>
 [ApiController]
 [Tags("Account")]
-[ApiVersion("1")]
-[ApiVersion("2")]
+[ApiVersion("1"), ApiVersion("2")]
 [Route("/{version:apiVersion}/account")]
 public sealed partial class AccountController : OpenShockControllerBase
 {

API/Controller/Devices/DevicesController.cs

@@ -146,7 +146,7 @@ public async Task<IActionResult> RemoveDevice([FromRoute] Guid deviceId, [FromSe
     /// <response code="201">Successfully created device</response>
     [HttpPost]
     [TokenPermission(PermissionType.Devices_Edit)]
-    [ProducesResponseType<Guid>(StatusCodes.Status201Created, MediaTypeNames.Application.Json)]
+    [ProducesResponseType<Guid>(StatusCodes.Status201Created, MediaTypeNames.Text.Plain)]
     [MapToApiVersion("1")]
     public Task<IActionResult> CreateDevice([FromServices] IDeviceUpdateService updateService)
     => CreateDeviceV2(new HubCreateRequest
@@ -161,7 +161,7 @@ public Task<IActionResult> CreateDevice([FromServices] IDeviceUpdateService upda
     /// <response code="201">Successfully created device</response>
     [HttpPost]
     [TokenPermission(PermissionType.Devices_Edit)]
-    [ProducesResponseType<Guid>(StatusCodes.Status201Created, MediaTypeNames.Application.Json)]
+    [ProducesResponseType<Guid>(StatusCodes.Status201Created, MediaTypeNames.Text.Plain)]
     [MapToApiVersion("2")]
     public async Task<IActionResult> CreateDeviceV2([FromBody] HubCreateRequest data, [FromServices] IDeviceUpdateService updateService)
     {

API/Controller/Devices/_ApiController.cs

@@ -13,8 +13,7 @@ namespace OpenShock.API.Controller.Devices;
 /// </summary>
 [ApiController]
 [Tags("Hub Management")]
-[ApiVersion("1")]
-[ApiVersion("2")]
+[ApiVersion("1"), ApiVersion("2")]
 [Route("/{version:apiVersion}/devices")]
 [Authorize(AuthenticationSchemes = OpenShockAuthSchemas.UserSessionApiTokenCombo)]
 public sealed partial class DevicesController : AuthenticatedSessionControllerBase

API/Controller/Shares/V2CreateShareRequest.cs

@@ -14,7 +14,7 @@ namespace OpenShock.API.Controller.Shares;
 public sealed partial class SharesController
 {
     [HttpPost("requests")]
-    [ProducesResponseType<Guid>(StatusCodes.Status200OK, MediaTypeNames.Application.Json)]
+    [ProducesResponseType<Guid>(StatusCodes.Status200OK, MediaTypeNames.Text.Plain)]
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status404NotFound, MediaTypeNames.Application.ProblemJson)] // UserNotFound, ShareCreateShockerNotFound
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status400BadRequest, MediaTypeNames.Application.ProblemJson)] // ShareCreateCannotShareWithSelf
     [ApiVersion("2")]

API/Controller/Shares/_ApiController.cs

@@ -12,8 +12,7 @@ namespace OpenShock.API.Controller.Shares;
 /// </summary>
 [ApiController]
 [Tags("Shocker Shares")]
-[ApiVersion("1")]
-[ApiVersion("2")]
+[ApiVersion("1"), ApiVersion("2")]
 [Route("/{version:apiVersion}/shares")]
 [Authorize(AuthenticationSchemes = OpenShockAuthSchemas.UserSessionApiTokenCombo)]
 public sealed partial class SharesController : AuthenticatedSessionControllerBase

API/Controller/Shockers/PauseShockerController.cs

@@ -24,7 +24,7 @@ public sealed partial class ShockerController
     /// <response code="404">Shocker not found or does not belong to you</response>
     [HttpPost("{shockerId}/pause")]
     [TokenPermission(PermissionType.Shockers_Pause)]
-    [ProducesResponseType<LegacyDataResponse<bool?>>(StatusCodes.Status200OK, MediaTypeNames.Application.Json)]
+    [ProducesResponseType<LegacyDataResponse<bool>>(StatusCodes.Status200OK, MediaTypeNames.Application.Json)]
     [ProducesResponseType<OpenShockProblem>(StatusCodes.Status404NotFound, MediaTypeNames.Application.ProblemJson)] // ShockerNotFound    
     [MapToApiVersion("1")]
     public async Task<IActionResult> PauseShocker([FromRoute] Guid shockerId, [FromBody] PauseRequest body,

API/Controller/Shockers/_ApiController.cs

@@ -12,8 +12,7 @@ namespace OpenShock.API.Controller.Shockers;
 /// </summary>
 [ApiController]
 [Tags("Shockers")]
-[ApiVersion("1")]
-[ApiVersion("2")]
+[ApiVersion("1"), ApiVersion("2")]
 [Route("/{version:apiVersion}/shockers")]
 [Authorize(AuthenticationSchemes = OpenShockAuthSchemas.UserSessionApiTokenCombo)]
 public sealed partial class ShockerController : AuthenticatedSessionControllerBase