From ecf587cb4fb225ec88617b519a22e0e1abf569df Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Tue, 14 Apr 2026 13:24:25 +0100 Subject: [PATCH 1/2] Add PID value for ENUM_LABEL now it's been included --- data/pid_data.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/data/pid_data.py b/data/pid_data.py index 26b46a30..98cf49cc 100644 --- a/data/pid_data.py +++ b/data/pid_data.py @@ -4785,18 +4785,6 @@ 'name': 'PARAMETER_DESCRIPTION', 'value': 81}, - # ENUM_LABEL - # TODO(Peter): There's currently no PID value defined for this in the released E1.20-2025 standard so we can't implement it! - # {'get_request': {'items': [{'name': 'pid', 'type': 'uint16'}, {'name': 'enumeration_index', 'type': 'uint32'}]}, - # 'get_response': {'items': [{'name': 'pid', 'type': 'uint16'}, {'name': 'enumeration_index', 'type': 'uint32'}, - # {'name': 'max_enumeration_index', 'type': 'uint32'}, - # {'name': 'description', - # 'max_size': 32, - # 'type': 'string'}]}, - # 'get_sub_device_range': 2, - # 'name': 'ENUM_LABEL', - # 'value': }, - # SUPPORTED_PARAMETERS_ENHANCED {'get_request': {'items': []}, 'get_response': {'items': [{'name': 'params', @@ -4881,6 +4869,17 @@ 'name': 'PACKED_PID_INDEX', 'value': 89}, + # ENUM_LABEL + {'get_request': {'items': [{'name': 'pid', 'type': 'uint16'}, {'name': 'enumeration_index', 'type': 'uint32'}]}, + 'get_response': {'items': [{'name': 'pid', 'type': 'uint16'}, {'name': 'enumeration_index', 'type': 'uint32'}, + {'name': 'max_enumeration_index', 'type': 'uint32'}, + {'name': 'description', + 'max_size': 32, + 'type': 'string'}]}, + 'get_sub_device_range': 2, + 'name': 'ENUM_LABEL', + 'value': 90}, + # TILT_INVERT {'get_request': {'items': []}, 'get_response': {'items': [{'name': 'invert', 'type': 'bool'}]}, From fd5a20a3fa5232b06e95ce867c68aa821f5cc8aa Mon Sep 17 00:00:00 2001 From: Peter Newman Date: Sun, 31 May 2026 23:26:25 +0100 Subject: [PATCH 2/2] Add ENUM_LABEL to the JS Disector --- js_src/rdm.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js_src/rdm.js b/js_src/rdm.js index a5ae40a8..9cb9fc00 100644 --- a/js_src/rdm.js +++ b/js_src/rdm.js @@ -69,6 +69,7 @@ angular.module('rdmApp', []) 'NACK_DESCRIPTION': 0x0057, 'PACKED_PID_SUB': 0x0058, 'PACKED_PID_INDEX': 0x0059, + 'ENUM_LABEL': 0x005a, 'DEVICE_INFO': 0x0060, 'PRODUCT_DETAIL_ID_LIST': 0x0070, 'DEVICE_MODEL_DESCRIPTION': 0x0080,