From b24a30bb04b8a7f0b0093d7078da24b253416b6f Mon Sep 17 00:00:00 2001 From: Derek Lewis Date: Wed, 19 Aug 2026 23:31:59 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8F=97=EF=B8=8F=F0=9F=94=A7=EF=BC=9Aauthe?= =?UTF-8?q?nticate=20the=20EditorConfig=20download?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit verify.validForEC fetches the editorconfig-checker binary from the GitHub API the first time it runs, and node_modules is new on every run here, so it fetches on every run. Unauthenticated that is 60 requests an hour shared with everything else leaving the same address, and #1834 failed on it having changed nothing that could possibly be related. The wrapper reads GITHUB_TOKEN and the runner is handed one, so the request is now authenticated and the limit is 5000. The binary is a Go program with no maintained JavaScript equivalent: eclint was last published in 2018 and editorconfig-tools in 2015. The npm package is the wrapper, and downloading is what it does. Signed-off-by: Derek Lewis Assisted-by: Claude-Code:claude-opus-5 --- .github/workflows/lint-and-test.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml index 6c01dd6db..9f49f338e 100644 --- a/.github/workflows/lint-and-test.yml +++ b/.github/workflows/lint-and-test.yml @@ -130,4 +130,11 @@ jobs: # everything runs, since nothing else checks what landed. - name: Test if: ${{ github.event_name == 'push' || steps.filter.outputs.js == 'true' || steps.filter.outputs.json == 'true' || steps.filter.outputs.ts == 'true' }} + # verify.validForEC fetches the editorconfig-checker binary from the + # GitHub API on first use, and node_modules is new on every run here. + # Unauthenticated that is 60 requests an hour shared with every other + # job leaving this address, which is a job failing for no reason of + # its own. The wrapper reads GITHUB_TOKEN and the runner is given one. + env: + GITHUB_TOKEN: ${{ github.token }} run: nps test