-
Notifications
You must be signed in to change notification settings - Fork 497
pointers to pointers considered harmful #421
Copy link
Copy link
Open
Labels
class-requirementIssue that can be traced back to a design requiementIssue that can be traced back to a design requiementdomain-productionPertains to the shippable code rather than any scaffoldingPertains to the shippable code rather than any scaffoldingpriority-lowA minor issueA minor issue
Milestone
Metadata
Metadata
Assignees
Labels
class-requirementIssue that can be traced back to a design requiementIssue that can be traced back to a design requiementdomain-productionPertains to the shippable code rather than any scaffoldingPertains to the shippable code rather than any scaffoldingpriority-lowA minor issueA minor issue
both
can_transport_implandudp_transport_implhavemakeTransportmethods that take a span ofIMedia*. This is a pointer to pointers which means a simple implementation with only one IMedia implementation has to add an additional memory location to store a pointer to the one implementation.Solutions include a different override for this case or
std::reference_wrapperin the span.