Skip to content

Commit 7332228

Browse files
committed
[CI] Install deps for backward compatibility check
On re-enabling the backward compatibility check that came with the ComfyUI cookiecutter project, it failed due to missing dependencies (specifically pytorch). So install dependencies before running the action. Choose dependencies from the PR rather than main, in case they are different, in the spirit of testing backward compatibility. Signed-off-by: David Feltell <david.feltell@foundry.com>
1 parent b79f3dc commit 7332228

1 file changed

Lines changed: 31 additions & 0 deletions

File tree

.github/workflows/validate.yml

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,37 @@ on:
1212

1313
jobs:
1414
validate:
15+
name: Validate backwards compatibility
1516
runs-on: ubuntu-latest
1617
steps:
18+
# We cannot simply run the node-diff action, since it will try
19+
# to import our package without installing dependencies. So we
20+
# install dependencies ourselves first.
21+
22+
- name: Set up Python
23+
uses: actions/setup-python@v5
24+
with:
25+
python-version: 3.10 # Same as comfy-org/node-diff
26+
27+
- name: Checkout PR
28+
uses: actions/checkout@v4
29+
with:
30+
path: pr_repo # Same as comfy-org/node-diff
31+
32+
- uses: actions/checkout@v4
33+
name: Checkout ComfyUI
34+
with:
35+
repository: comfyanonymous/ComfyUI
36+
ref: v0.3.57
37+
path: comfyui
38+
39+
- name: Install dependencies
40+
shell: bash
41+
run: |
42+
python -m pip install --upgrade pip
43+
pip install ./pr_repo
44+
pip install -r ./comfyui/requirements.txt
45+
1746
- uses: comfy-org/node-diff@main
47+
env:
48+
PYTHONPATH: ${{ github.workspace }}/comfyui

0 commit comments

Comments
 (0)