Skip to content

Commit 1d461d1

Browse files
committed
OXDEV-9127 Use backported methods for test parameters
1 parent a5c9869 commit 1d461d1

2 files changed

Lines changed: 31 additions & 14 deletions

File tree

tests/Codeception/Acceptance.suite.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,25 @@ path: Acceptance
44
modules:
55
enabled:
66
- Asserts
7+
- \OxidEsales\Codeception\Module\ShopSetup:
8+
dump: '%DUMP_PATH%'
9+
fixtures: '%FIXTURES_PATH%'
10+
license: '%license_key%'
11+
mysql_config: '%MYSQL_CONFIG_PATH%'
12+
db_name: '%DB_NAME%'
713
- Db:
814
dsn: 'mysql:host=%DB_HOST%;dbname=%DB_NAME%;charset=utf8'
915
user: '%DB_USERNAME%'
1016
password: '%DB_PASSWORD%'
1117
port: '%DB_PORT%'
1218
module_dump: '%MODULE_DUMP_PATH%'
19+
dump: '%DUMP_PATH%'
1320
mysql_config: '%MYSQL_CONFIG_PATH%'
1421
populate: true # run populator before all tests
15-
cleanup: false # run populator before each test
16-
populator: 'mysql --defaults-file=$mysql_config --default-character-set=utf8 $dbname < $module_dump'
17-
- \OxidEsales\Codeception\Module\Database:
18-
config_key: 'fq45QS09_fqyx09239QQ'
19-
depends: Db
22+
cleanup: true # run populator before each test
23+
populator: >
24+
mysql --defaults-file=$mysql_config --default-character-set=utf8 $dbname < $dump &&
25+
mysql --defaults-file=$mysql_config --default-character-set=utf8 $dbname < $module_dump
2026
- REST:
2127
url: '%SHOP_URL%'
2228
depends: PhpBrowser

tests/Codeception/Config/CodeceptionParametersProvider.php

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99

1010
namespace OxidEsales\GraphQL\Base\Tests\Codeception\Config;
1111

12-
use OxidEsales\Codeception\Module\Database\DatabaseDefaultsFileGenerator;
13-
use OxidEsales\Facts\Config\ConfigFile;
12+
use OxidEsales\Codeception\Module\Database;
1413
use OxidEsales\Facts\Facts;
1514
use Symfony\Component\Filesystem\Path;
1615

@@ -34,25 +33,37 @@ public function getParameters(): array
3433
'DB_PASSWORD' => $facts->getDatabasePassword(),
3534
'DB_HOST' => $facts->getDatabaseHost(),
3635
'DB_PORT' => $facts->getDatabasePort(),
36+
'DUMP_PATH' => $this->getTestDataDumpFilePath(),
3737
'MODULE_DUMP_PATH' => $this->getModuleTestDataDumpFilePath(),
38-
'MYSQL_CONFIG_PATH' => $this->getMysqlConfigPath(),
38+
'MYSQL_CONFIG_PATH' => $this->generateMysqlStarUpConfigurationFile($facts),
3939
'PHP_BIN' => $php,
40+
'FIXTURES_PATH' => $this->getFixturesFilePath()
4041
];
4142
}
4243

43-
private function getModuleTestDataDumpFilePath()
44+
private function getModuleTestDataDumpFilePath(): string
4445
{
4546
return Path::join(__DIR__, '..', 'Support', 'Data', 'dump.sql');
4647
}
4748

48-
private function getMysqlConfigPath()
49+
private function getFixturesFilePath(): string
4950
{
50-
$facts = new Facts();
51-
$configFile = new ConfigFile($facts->getSourcePath() . '/config.inc.php');
51+
return Path::join(__DIR__, '..', 'Support', 'Data', 'fixtures.sql');
52+
}
5253

53-
$generator = new DatabaseDefaultsFileGenerator($configFile);
54+
private function getTestDataDumpFilePath(): string
55+
{
56+
return Path::join(__DIR__, '..', 'Support', '_generated', 'shop-dump.sql');
57+
}
5458

55-
return $generator->generate();
59+
private function generateMysqlStarUpConfigurationFile(Facts $facts): string
60+
{
61+
return Database::generateStartupOptionsFile(
62+
user: $facts->getDatabaseUserName(),
63+
pass: $facts->getDatabasePassword(),
64+
host: $facts->getDatabaseHost(),
65+
port: $facts->getDatabasePort()
66+
);
5667
}
5768
}
5869

0 commit comments

Comments
 (0)