patch: fix AWS_BUCKET_NAME default incorrect syntax

Author: TotalDwarf03

terraform/service/main.tf

@@ -52,7 +52,7 @@ resource "aws_lambda_function" "lambda_function" {
       GITHUB_APP_CLIENT_ID = var.github_app_client_id
       AWS_SECRET_NAME      = var.aws_secret_name
       AWS_ACCOUNT_NAME     = var.env_name
-      AWS_BUCKET_NAME      = var.aws_bucket_name
+      AWS_BUCKET_NAME      = local.bucket_name
     }
   }
 }

terraform/service/variables.tf

@@ -19,9 +19,9 @@ variable "aws_secret_name" {
 }
 
 variable "aws_bucket_name" {
-  description = "The name of the S3 bucket which the cloud config is stored in"
+  description = "The name of the S3 bucket which the cloud config is stored in. This should not include the environment name (i.e. sdp-dev) as it will be added automatically."
   type        = string
-  default     = "${env_name}-github-repository-archive-script"
+  default     = "github-repository-archive-script"
 }
 
 variable "env_name" {
@@ -109,4 +109,5 @@ variable "business_owner_tag" {
 
 locals {
   lambda_repo = "${var.env_name}-${var.lambda_name}"
+  bucket_name = "${var.env_name}-${var.aws_bucket_name}"
 }