[MIG] web_pwa_customize: Migration to 19.0

Author: AnmollGarg

web_pwa_customize/models/res_config_settings.py

@@ -6,7 +6,7 @@
 
 from PIL import Image
 
-from odoo import _, api, exceptions, fields, models
+from odoo import api, exceptions, fields, models
 from odoo.tools.mimetypes import guess_mimetype
 
 
@@ -97,7 +97,7 @@ def set_values(self):
         # Fail if icon provided is larger than 2mb
         if sys.getsizeof(self.pwa_icon) > 2196608:
             raise exceptions.UserError(
-                _("You can't upload a file with more than 2 MB.")
+                self.env._("You can't upload a file with more than 2 MB.")
             )
         # Confirm if the pwa_icon binary content is an SVG or PNG
         # and process accordingly
@@ -109,8 +109,10 @@ def set_values(self):
             "image/svg"
         ) and not pwa_icon_mimetype.startswith("image/png"):
             raise exceptions.UserError(
-                _("You can only upload SVG or PNG files. Found: %s.")
-                % pwa_icon_mimetype
+                self.env._(
+                    "You can only upload SVG or PNG files. Found: %s.",
+                    pwa_icon_mimetype,
+                )
             )
         # Delete all previous records if we are writting new ones
         if pwa_icon_ir_attachments:
@@ -121,7 +123,7 @@ def set_values(self):
             # Fail if provided PNG is smaller than 512x512
             if self._unpack_icon(self.pwa_icon).size < (512, 512):
                 raise exceptions.UserError(
-                    _("You can only upload PNG files bigger than 512x512")
+                    self.env._("You can only upload PNG files bigger than 512x512")
                 )
             for size in [
                 (128, 128),

web_pwa_customize/tests/test_web_pwa_customize.py

@@ -1,6 +1,12 @@
+import base64
+import io
+
+from PIL import Image
+
+from odoo import exceptions
+
 # Copyright 2024 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-
 from odoo.tests.common import tagged
 
 from odoo.addons.base.tests.common import HttpCaseWithUserDemo
@@ -24,3 +30,89 @@ def test_webmanifest_customize(self):
         self.assertEqual(data["short_name"], "SHORT-NAME")
         self.assertEqual(data["background_color"], "#2E69B5")
         self.assertEqual(data["theme_color"], "#2E69B4")
+
+    def test_pwa_settings_processing(self):
+        """Test the settings logic and icon attachment generation"""
+
+        # 1. Test PNG (valid 512x512)
+        img = Image.new("RGB", (512, 512), color="red")
+        img_byte_arr = io.BytesIO()
+        img.save(img_byte_arr, format="PNG")
+        icon_base64 = base64.b64encode(img_byte_arr.getvalue())
+
+        config = self.env["res.config.settings"].create(
+            {
+                "pwa_short_name": "New Name",
+                "pwa_icon": icon_base64,
+            }
+        )
+        config.execute()
+
+        # Check manifest endpoint with icons
+        response = self.url_open("/web/manifest.webmanifest")
+        data = response.json()
+        self.assertIn("icons", data)
+        self.assertGreaterEqual(len(data["icons"]), 6)
+
+        # 2. Test SVG (valid)
+        svg_content = (
+            '<svg width="100" height="100">'
+            '<circle cx="50" cy="50" r="40" stroke="green" '
+            'stroke-width="4" fill="yellow" />'
+            "</svg>"
+        )
+        svg_base64 = base64.b64encode(svg_content)
+        config.write({"pwa_icon": svg_base64})
+        config.execute()
+
+        response = self.url_open("/web/manifest.webmanifest")
+        data = response.json()
+        self.assertEqual(len(data["icons"]), 1)
+        self.assertEqual(data["icons"][0]["type"], "image/svg+xml")
+
+        # 3. Test Clearing Icons
+        config.write({"pwa_icon": False})
+        config.execute()
+        attachments = self.env["ir.attachment"].search(
+            [("url", "like", "/web_pwa_customize/icon")]
+        )
+        self.assertEqual(len(attachments), 0)
+
+        # 4. Test PNG too small (< 512x512)
+        small_img = Image.new("RGB", (100, 100), color="blue")
+        small_img_byte_arr = io.BytesIO()
+        small_img.save(small_img_byte_arr, format="PNG")
+        small_icon_base64 = base64.b64encode(small_img_byte_arr.getvalue())
+
+        with self.assertRaises(exceptions.UserError):
+            config.write({"pwa_icon": small_icon_base64})
+            config.execute()
+
+        # 5. Test File too large (> 2 MB)
+        large_content = b"0" * (2 * 1024 * 1024 + 1024)  # Slightly over 2MB
+        large_base64 = base64.b64encode(large_content)
+        with self.assertRaises(exceptions.UserError):
+            config.write({"pwa_icon": large_base64})
+            config.execute()
+
+        # 6. Test Invalid Image type (gif)
+        gif_img = Image.new("RGB", (512, 512), color="green")
+        gif_byte_arr = io.BytesIO()
+        gif_img.save(gif_byte_arr, format="GIF")
+        gif_base64 = base64.b64encode(gif_byte_arr.getvalue())
+        with self.assertRaises(exceptions.UserError):
+            config.write({"pwa_icon": gif_base64})
+            config.execute()
+
+    def test_default_get_colors(self):
+        """Test default colors are set in res.config.settings"""
+        # Clear ICP to test defaults
+        icp = self.env["ir.config_parameter"].sudo()
+        icp.set_param("pwa.manifest.background_color", False)
+        icp.set_param("pwa.manifest.theme_color", False)
+
+        res = self.env["res.config.settings"].default_get(
+            ["pwa_background_color", "pwa_theme_color"]
+        )
+        self.assertEqual(res.get("pwa_background_color"), "#714B67")
+        self.assertEqual(res.get("pwa_theme_color"), "#714B67")