[IMP] database_cleanup: changes from review

Author: Aldeigja

database_cleanup/models/purge_attachments.py

@@ -6,13 +6,20 @@
 from odoo import _, api, fields, models
 from odoo.exceptions import AccessError, UserError, ValidationError
 
+REASON_MISSING_FILE = "missing_file"
+
 
 class CleanupPurgeLineAttachment(models.TransientModel):
     _inherit = "cleanup.purge.line"
     _name = "cleanup.purge.line.attachment"
     _description = "Cleanup Purge Line Attachment"
 
     attachment_id = fields.Many2one("ir.attachment")
+    reason = fields.Selection(
+        [
+            (REASON_MISSING_FILE, ("File missing in filestore")),
+        ],
+    )
     wizard_id = fields.Many2one("cleanup.purge.wizard.attachment", readonly=True)
 
     def purge(self):
@@ -92,6 +99,7 @@ def find(self):
                         {
                             "attachment_id": attach.id,
                             "name": attach.store_fname or attach.name or str(attach.id),
+                            "reason": REASON_MISSING_FILE,
                         },
                     )
                 )

database_cleanup/tests/test_purge_attachments.py

@@ -6,6 +6,7 @@
 from unittest.mock import patch
 
 from odoo.exceptions import UserError
+from odoo.fields import Command
 from odoo.tests.common import tagged
 
 from .common import Common, environment
@@ -117,22 +118,18 @@ def patched_unlink(self):
             wizard = env["cleanup.purge.wizard.attachment"].create(
                 {
                     "purge_line_ids": [
-                        (
-                            0,
-                            0,
+                        Command.create(
                             {
                                 "attachment_id": protected_id,
                                 "name": orphan_protected.store_fname
                                 or str(protected_id),
-                            },
+                            }
                         ),
-                        (
-                            0,
-                            0,
+                        Command.create(
                             {
                                 "attachment_id": other_id,
                                 "name": orphan_other.store_fname or str(other_id),
-                            },
+                            }
                         ),
                     ],
                 }

database_cleanup/views/purge_attachments.xml

@@ -7,6 +7,7 @@
         <field name="arch" type="xml">
             <field name="name" position="after">
                 <field name="attachment_id" />
+                <field name="reason" />
             </field>
         </field>
     </record>
@@ -31,6 +32,7 @@
         <field name="arch" type="xml">
             <field name="name" position="after">
                 <field name="attachment_id" />
+                <field name="reason" />
             </field>
         </field>
     </record>