[IMP] mis_builder: pre-commit fixes.

Author: Qlasta

mis_builder/models/mis_report.py

@@ -447,7 +447,7 @@ def _default_move_lines_source(self):
             ("field_id.name", "=", "date"),
             ("field_id.name", "=", "company_id"),
         ],
-        default=_default_move_lines_source,
+        default=lambda self: self._default_move_lines_source(),
         required=True,
         ondelete="cascade",
         help="A 'move line like' model, ie having at least debit, credit, "

mis_builder/models/mis_report_style.py

@@ -3,7 +3,6 @@
 # Copyright 2020 CorporateHub (https://corporatehub.eu)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
-import sys
 
 from odoo import api, fields, models
 from odoo.exceptions import ValidationError
@@ -12,15 +11,13 @@
 from .accounting_none import AccountingNone
 from .data_error import DataError
 
-if sys.version_info.major >= 3:
-    unicode = str
-
 
 class PropertyDict(dict):
     def __getattr__(self, name):
         return self.get(name)
 
-    def copy(self):  # pylint: disable=copy-wo-api-one,method-required-super
+    # pylint: disable=method-required-super
+    def copy(self):
         return PropertyDict(self)
 
 
@@ -224,7 +221,8 @@ def render_num(
         if value is None or value is AccountingNone:
             return ""
         value = float_round(value / float(divider or 1), dp or 0) or 0
-        r = lang.format("%%%s.%df" % (sign, dp or 0), value, grouping=True)
+        format_str = f"%{sign}.{dp or 0}f"
+        r = lang.format(format_str, value, grouping=True)
         r = r.replace("-", "\N{NON-BREAKING HYPHEN}")
         if prefix:
             r = prefix + "\N{NO-BREAK SPACE}" + r
@@ -240,7 +238,7 @@ def render_pct(self, lang, value, dp=1, sign="-"):
     def render_str(self, lang, value):
         if value is None or value is AccountingNone:
             return ""
-        return unicode(value)
+        return str(value)
 
     @api.model
     def compare_and_render(
@@ -287,10 +285,8 @@ def compare_and_render(
                 delta = AccountingNone
         elif var_type == TYPE_NUM:
             if value and average_value:
-                # pylint: disable=redefined-variable-type
                 value = value / float(average_value)
             if base_value and average_base_value:
-                # pylint: disable=redefined-variable-type
                 base_value = base_value / float(average_base_value)
             if compare_method == CMP_DIFF:
                 delta = value - base_value

mis_builder/tests/common.py

@@ -26,9 +26,9 @@ def assert_matrix(matrix, expected):
         if row is not None and expected_row is None:
             raise AssertionError("too many rows")
         for j, cell, expected_val in _zip(row.iter_cells(), expected_row):
-            assert (
-                (cell and cell.val) == expected_val
-            ), f"{cell and cell.val} != {expected_val} in row {i} col {j}"
+            assert (cell and cell.val) == expected_val, (
+                f"{cell and cell.val} != {expected_val} in row {i} col {j}"
+            )
 
 
 @tagged("doctest")

mis_builder/tests/test_period_dates.py

@@ -124,9 +124,9 @@ def test_rel_date_range(self):
             self.env["date.range"].create(
                 dict(
                     type_id=date_range_type.id,
-                    name="%d" % year,
-                    date_start="%d-01-01" % year,
-                    date_end="%d-12-31" % year,
+                    name=f"{year}",
+                    date_start=f"{year}-01-01",
+                    date_end=f"{year}-12-31",
                     company_id=date_range_type.company_id.id,
                 )
             )

mis_builder/wizard/mis_builder_dashboard.py

@@ -17,7 +17,7 @@ class AddMisReportInstanceDashboard(models.TransientModel):
         "ir.actions.act_window",
         string="Dashboard",
         required=True,
-        domain="[('res_model', '=', " "'board.board')]",
+        domain="[('res_model', '=', 'board.board')]",
     )
 
     @api.model