[19.0][MIG] mail_composer_cc_bcc: Migration to 19.0

Author: cyrilmanuel

mail_composer_cc_bcc/README.rst

@@ -21,13 +21,13 @@ Email CC and BCC
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github
-    :target: https://github.com/OCA/mail/tree/18.0/mail_composer_cc_bcc
+    :target: https://github.com/OCA/mail/tree/19.0/mail_composer_cc_bcc
     :alt: OCA/mail
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc
+    :target: https://translation.odoo-community.org/projects/mail-19-0/mail-19-0-mail_composer_cc_bcc
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/mail&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -72,8 +72,8 @@ In template form there are two fields to set cc and bcc emails.
 
    |email_template_form_cc_bcc|
 
-.. |res_company_form_default_cc_bcc| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/res_company_form_default_cc_bcc.png
-.. |email_template_form_cc_bcc| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/email_template_form_cc_bcc.png
+.. |res_company_form_default_cc_bcc| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/res_company_form_default_cc_bcc.png
+.. |email_template_form_cc_bcc| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/email_template_form_cc_bcc.png
 
 Usage
 =====
@@ -89,16 +89,16 @@ corresponding mail composer's fields.
 
    |image1|
 
-.. |image| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/mail_compose_message_default_cc_bcc.png
-.. |image1| image:: https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/mail_compose_message_template_cc_bcc.png
+.. |image| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/mail_compose_message_default_cc_bcc.png
+.. |image1| image:: https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/mail_compose_message_template_cc_bcc.png
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/mail/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_composer_cc_bcc%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/mail/issues/new?body=module:%20mail_composer_cc_bcc%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -148,6 +148,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-trisdoan| 
 
-This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/18.0/mail_composer_cc_bcc>`_ project on GitHub.
+This module is part of the `OCA/mail <https://github.com/OCA/mail/tree/19.0/mail_composer_cc_bcc>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

mail_composer_cc_bcc/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Email CC and BCC",
     "summary": "This module enables sending mail to CC and BCC partners in mail composer form.",  # noqa: E501
-    "version": "18.0.1.0.2",
+    "version": "19.0.1.0.0",
     "development_status": "Alpha",
     "category": "Social",
     "website": "https://github.com/OCA/mail",

mail_composer_cc_bcc/models/mail_mail.py

@@ -25,13 +25,15 @@ class MailMail(models.Model):
 
     email_bcc = fields.Char("Bcc", help="Blind Cc message recipients")
 
-    def _prepare_outgoing_list(
-        self, mail_server=False, recipients_follower_status=None
-    ):
+    # this method change on odoo 19.0
+    #  def _prepare_outgoing_list(self, mail_server=False, doc_to_followers=None):
+    # TODO verify the code with the change doc_to_followers
+
+    def _prepare_outgoing_list(self, mail_server=False, doc_to_followers=None):
         # First, return if we're not coming from the Mail Composer
         res = super()._prepare_outgoing_list(
             mail_server=mail_server,
-            recipients_follower_status=recipients_follower_status,
+            doc_to_followers=doc_to_followers,
         )
         is_out_of_scope = len(self.ids) > 1
         is_from_composer = self.env.context.get("is_from_composer", False)

mail_composer_cc_bcc/models/mail_thread.py

@@ -25,13 +25,20 @@ def _get_message_create_valid_field_names(self):
     # NOTIFICATION API
     # ------------------------------------------------------
 
-    def _notify_by_email_get_base_mail_values(self, message, additional_values=None):
+    # this method change on odoo 19.0
+    # def _notify_by_email_get_base_mail_values(self, message,
+    #   recipients_data, additional_values=None):
+    # TODO verify the code with the change doc_to_followers
+
+    def _notify_by_email_get_base_mail_values(
+        self, message, recipients_data, additional_values=None
+    ):
         """
         This is to add cc, bcc addresses to mail.mail objects so that email
         can be sent to those addresses.
         """
         res = super()._notify_by_email_get_base_mail_values(
-            message, additional_values=additional_values
+            message, recipients_data, additional_values=additional_values
         )
         context = self.env.context
         skip_adding_cc_bcc = context.get("skip_adding_cc_bcc", False)
@@ -48,7 +55,7 @@ def _notify_by_email_get_base_mail_values(self, message, additional_values=None)
 
         return res
 
-    def _notify_get_recipients(self, message, msg_vals, **kwargs):
+    def _notify_get_recipients(self, message, msg_vals=False, **kwargs):
         """
         This is to add cc, bcc recipients so that they can be grouped with
         other recipients.

mail_composer_cc_bcc/static/description/index.html

@@ -8,11 +8,10 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -363,9 +362,7 @@
 <div class="document">
 
 
-<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
-<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme"><img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" /></a>
 <div class="section" id="email-cc-and-bcc">
 <h1>Email CC and BCC</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
@@ -374,7 +371,7 @@ <h1>Email CC and BCC</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:baa3864e6fc3754462520ec7eb76d0d09dbffbedbb627a99fe17c092ee3cf57f
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/mail/tree/18.0/mail_composer_cc_bcc"><img alt="OCA/mail" src="https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/mail&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/mail/tree/19.0/mail_composer_cc_bcc"><img alt="OCA/mail" src="https://img.shields.io/badge/github-OCA%2Fmail-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/mail-19-0/mail-19-0-mail_composer_cc_bcc"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/mail&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Odoo native does not support defining a Cc field in the Mail Composer by
 default; instead, it only has a unique Recipients fields, which is
 confusing for a lot of end users.</p>
@@ -410,29 +407,29 @@ <h2>Features</h2>
 <h3><a class="toc-backref" href="#toc-entry-1">Configuration</a></h3>
 <p>In company form there are two fields to set default cc and bcc partners.</p>
 <blockquote>
-<img alt="res_company_form_default_cc_bcc" src="https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/res_company_form_default_cc_bcc.png" /></blockquote>
+<img alt="res_company_form_default_cc_bcc" src="https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/res_company_form_default_cc_bcc.png" /></blockquote>
 <p>In template form there are two fields to set cc and bcc emails.</p>
 <blockquote>
-<img alt="email_template_form_cc_bcc" src="https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/email_template_form_cc_bcc.png" /></blockquote>
+<img alt="email_template_form_cc_bcc" src="https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/email_template_form_cc_bcc.png" /></blockquote>
 </div>
 <div class="section" id="usage">
 <h3><a class="toc-backref" href="#toc-entry-2">Usage</a></h3>
 <p>The partners cc and bcc from company form will be used to fill in mail
 composer form.</p>
 <blockquote>
-<img alt="image" src="https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/mail_compose_message_default_cc_bcc.png" /></blockquote>
+<img alt="image" src="https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/mail_compose_message_default_cc_bcc.png" /></blockquote>
 <p>When select a template that has cc and/or bcc emails, the emails will be
 used to lookup partners then found partners will be added to
 corresponding mail composer’s fields.</p>
 <blockquote>
-<img alt="image1" src="https://raw.githubusercontent.com/OCA/mail/18.0/mail_composer_cc_bcc/static/img/mail_compose_message_template_cc_bcc.png" /></blockquote>
+<img alt="image1" src="https://raw.githubusercontent.com/OCA/mail/19.0/mail_composer_cc_bcc/static/img/mail_compose_message_template_cc_bcc.png" /></blockquote>
 </div>
 <div class="section" id="bug-tracker">
 <h3><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h3>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/mail/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/mail/issues/new?body=module:%20mail_composer_cc_bcc%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/mail/issues/new?body=module:%20mail_composer_cc_bcc%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -469,15 +466,13 @@ <h2>Other credits</h2>
 <div class="section" id="maintainers">
 <h2>Maintainers</h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/trisdoan"><img alt="trisdoan" src="https://github.com/trisdoan.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/mail/tree/18.0/mail_composer_cc_bcc">OCA/mail</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/mail/tree/19.0/mail_composer_cc_bcc">OCA/mail</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

mail_composer_cc_bcc/tests/test_mail_cc_bcc.py

@@ -10,7 +10,7 @@
 from odoo.addons.mail.tests.common import MailCase
 from odoo.addons.mail.tests.test_mail_composer import TestMailComposerForm
 from odoo.addons.mail.wizard.mail_compose_message import (
-    MailComposer as MailComposer_upstream,
+    MailComposeMessage as MailComposeMessage_upstream,
 )
 
 VALID_HASHES = {
@@ -43,10 +43,10 @@ def open_mail_composer_form(self):
         form.body = "<p>Hello</p>"
         return form
 
-    def test_MailComposer_upstream_file_hash(self):
+    def test_MailComposeMessage_upstream_file_hash(self):
         """Test that copied upstream function hasn't received fixes"""
         _compute_partner_ids = inspect.getsource(
-            MailComposer_upstream._compute_partner_ids
+            MailComposeMessage_upstream._compute_partner_ids
         ).encode()
         func_hash = hashlib.md5(_compute_partner_ids).hexdigest()
         self.assertIn(func_hash, VALID_HASHES.get("mail.composer:_compute_partner_ids"))