[MIG] fleet_vehicle_stock: Migration to 18.0

Author: JulioFabio

fleet_vehicle_stock/__manifest__.py

@@ -7,12 +7,11 @@
     "summary": """
         This module is an add-on for the Fleet application in Odoo. It allows
         you to track your Fleet Vehicles in stock moves.""",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "Escodoo,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/fleet",
     "category": "Human Resources/Fleet",
-    "images": ["static/description/banner.png"],
     "maintainers": ["marcelsavegnago"],
     "depends": ["stock", "fleet"],
     "data": [

fleet_vehicle_stock/models/fleet_vehicle.py

@@ -46,13 +46,13 @@ def _onchange_product(self):
             rec.lot_id = False
             rec.current_stock_location_id = False
 
-    @api.model
-    def create(self, vals):
-        res = super().create(vals)
-        if res.lot_id:
-            if "lot_id" in vals:
-                res.lot_id.fleet_vehicle_id = res.id
-        return res
+    @api.model_create_multi
+    def create(self, vals_list):
+        records = super().create(vals_list)
+        for record, vals in zip(records, vals_list, strict=False):
+            if record.lot_id and "lot_id" in vals:
+                record.lot_id.fleet_vehicle_id = record.id
+        return records
 
     def write(self, vals):
         for rec in self:

fleet_vehicle_stock/models/stock_move.py

@@ -26,7 +26,7 @@ def _action_done(self, cancel_backorder=False):
             ):
                 raise UserError(
                     _(
-                        "The product '%s' is configure to create a fleet "
+                        "The product '%s' is configured to create a fleet "
                         "vehicle but vehicle model is not configured in the "
                         "product."
                     )

fleet_vehicle_stock/tests/test_fleet_vehicle.py

@@ -1,6 +1,7 @@
 # Copyright (C) 2021 - TODAY, Marcel Savegnago <marcel.savegnago@escodoo.com.br>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
+from odoo.exceptions import UserError
 from odoo.tests.common import TransactionCase
 
 
@@ -21,15 +22,17 @@ def setUpClass(cls):
         cls.product1 = cls.env["product.product"].create(
             {
                 "name": "Product 1",
-                "type": "product",
+                "is_storable": True,
+                "type": "consu",
                 "fleet_vehicle_model_id": cls.vehicle_model1.id,
                 "tracking": "serial",
             }
         )
         cls.product2 = cls.env["product.product"].create(
             {
                 "name": "Product 2",
-                "type": "product",
+                "is_storable": True,
+                "type": "consu",
                 "fleet_vehicle_model_id": cls.vehicle_model1.id,
                 "tracking": "serial",
             }
@@ -89,8 +92,203 @@ def test_compute_current_stock_loc_id(self):
 
     def test_inverse_fleet_vehicle_model_id(self):
         product2 = self.product2
+        self.assertEqual(len(product2.product_variant_ids), 1)
+
         product2.fleet_vehicle_model_id = self.vehicle_model2
         self.assertEqual(
             product2.product_variant_ids.fleet_vehicle_model_id,
             product2.fleet_vehicle_model_id,
         )
+
+    def test_create_product_template_with_model(self):
+        product_tmpl = self.env["product.template"].create(
+            {
+                "name": "Product Template With Model",
+                "fleet_vehicle_model_id": self.vehicle_model1.id,
+                "tracking": "serial",
+            }
+        )
+        self.assertEqual(product_tmpl.fleet_vehicle_model_id, self.vehicle_model1)
+        self.assertEqual(len(product_tmpl.product_variant_ids), 1)
+        self.assertEqual(
+            product_tmpl.product_variant_ids.fleet_vehicle_model_id, self.vehicle_model1
+        )
+
+    def test_stock_move_create_vehicle(self):
+        picking_type = self.env["stock.picking.type"].create(
+            {
+                "name": "Test Picking Type",
+                "code": "incoming",
+                "sequence_code": "TPT",
+                "create_fleet_vehicle": True,
+            }
+        )
+        self.product1.product_tmpl_id.create_fleet_vehicle = True
+
+        move = self.env["stock.move"].create(
+            {
+                "name": "Test Move",
+                "product_id": self.product1.id,
+                "product_uom_qty": 1.0,
+                "product_uom": self.product1.uom_id.id,
+                "location_id": self.env.ref("stock.stock_location_suppliers").id,
+                "location_dest_id": self.stock_location.id,
+                "picking_type_id": picking_type.id,
+            }
+        )
+        move._action_confirm()
+
+        lot = self.env["stock.lot"].create(
+            {
+                "name": "new_serial",
+                "product_id": self.product1.id,
+                "company_id": self.env.user.company_id.id,
+            }
+        )
+
+        move.move_line_ids.write({"quantity": 1.0, "lot_id": lot.id})
+
+        move.picked = True
+        move._action_done()
+
+        self.assertTrue(lot.fleet_vehicle_id)
+        self.assertEqual(lot.fleet_vehicle_id.model_id, self.vehicle_model1)
+        self.assertEqual(lot.fleet_vehicle_id.product_id, self.product1)
+        self.assertEqual(
+            lot.fleet_vehicle_id.current_stock_location_id, self.stock_location
+        )
+
+    def test_stock_move_skip_vehicle_creation(self):
+        picking_type_no_create = self.env["stock.picking.type"].create(
+            {
+                "name": "Test Picking Type No Create",
+                "code": "incoming",
+                "sequence_code": "TPTNC",
+                "create_fleet_vehicle": False,
+            }
+        )
+        self.product1.product_tmpl_id.create_fleet_vehicle = True
+
+        move1 = self.env["stock.move"].create(
+            {
+                "name": "Test Move Skip 1",
+                "product_id": self.product1.id,
+                "product_uom_qty": 1.0,
+                "product_uom": self.product1.uom_id.id,
+                "location_id": self.env.ref("stock.stock_location_suppliers").id,
+                "location_dest_id": self.stock_location.id,
+                "picking_type_id": picking_type_no_create.id,
+            }
+        )
+        move1._action_confirm()
+        lot1 = self.env["stock.lot"].create(
+            {
+                "name": "serial_skip_1",
+                "product_id": self.product1.id,
+                "company_id": self.env.user.company_id.id,
+            }
+        )
+        move1.move_line_ids.write({"quantity": 1.0, "lot_id": lot1.id})
+        move1.picked = True
+        move1._action_done()
+        self.assertFalse(
+            lot1.fleet_vehicle_id,
+            "Vehicle should not be created if picking type disabled",
+        )
+
+        picking_type_create = self.env["stock.picking.type"].create(
+            {
+                "name": "Test Picking Type Create",
+                "code": "incoming",
+                "sequence_code": "TPTC",
+                "create_fleet_vehicle": True,
+            }
+        )
+        self.product1.product_tmpl_id.create_fleet_vehicle = False
+
+        move2 = self.env["stock.move"].create(
+            {
+                "name": "Test Move Skip 2",
+                "product_id": self.product1.id,
+                "product_uom_qty": 1.0,
+                "product_uom": self.product1.uom_id.id,
+                "location_id": self.env.ref("stock.stock_location_suppliers").id,
+                "location_dest_id": self.stock_location.id,
+                "picking_type_id": picking_type_create.id,
+            }
+        )
+        move2._action_confirm()
+        lot2 = self.env["stock.lot"].create(
+            {
+                "name": "serial_skip_2",
+                "product_id": self.product1.id,
+                "company_id": self.env.user.company_id.id,
+            }
+        )
+        move2.move_line_ids.write({"quantity": 1.0, "lot_id": lot2.id})
+        move2.picked = True
+        move2._action_done()
+        self.assertFalse(
+            lot2.fleet_vehicle_id,
+            "Vehicle should not be created if product template disabled",
+        )
+
+    def test_create_fleet_vehicle_updates_lot(self):
+        lot = self.env["stock.lot"].create(
+            {
+                "name": "serial_vehicle_create",
+                "product_id": self.product1.id,
+                "company_id": self.env.user.company_id.id,
+            }
+        )
+
+        vehicle = self.env["fleet.vehicle"].create(
+            {
+                "model_id": self.vehicle_model1.id,
+                "product_id": self.product1.id,
+                "lot_id": lot.id,
+            }
+        )
+
+        self.assertEqual(
+            lot.fleet_vehicle_id, vehicle, "Lot should be linked to the created vehicle"
+        )
+
+    def test_create_fleet_vehicle_no_lot(self):
+        vehicle1 = self.env["fleet.vehicle"].create(
+            {
+                "model_id": self.vehicle_model1.id,
+                "product_id": self.product1.id,
+            }
+        )
+        self.assertFalse(vehicle1.lot_id, "Vehicle should have no lot")
+        vehicle2 = self.env["fleet.vehicle"].create(
+            {
+                "model_id": self.vehicle_model1.id,
+                "product_id": self.product1.id,
+                "lot_id": False,
+            }
+        )
+        self.assertFalse(vehicle2.lot_id, "Vehicle should have no lot")
+
+    def test_stock_move_error(self):
+        product_no_model = self.env["product.product"].create(
+            {
+                "name": "Product No Model",
+                "is_storable": True,
+                "create_fleet_vehicle": True,
+            }
+        )
+
+        move = self.env["stock.move"].create(
+            {
+                "name": "Test Move Error",
+                "product_id": product_no_model.id,
+                "product_uom_qty": 1.0,
+                "location_id": self.env.ref("stock.stock_location_suppliers").id,
+                "location_dest_id": self.stock_location.id,
+            }
+        )
+
+        with self.assertRaises(UserError):
+            move._action_done()

fleet_vehicle_stock/views/product_product.xml

@@ -13,7 +13,8 @@
                 <group>
                     <field
                         name="fleet_vehicle_model_id"
-                        attrs="{'invisible': [('tracking', '!=', 'serial')], 'required': [('create_fleet_vehicle', '=', True)]}"
+                        invisible="tracking != 'serial'"
+                        required="create_fleet_vehicle == True"
                     />
                 </group>
             </page>
@@ -37,7 +38,8 @@
                 >
                     <field
                         name="fleet_vehicle_model_id"
-                        attrs="{'invisible': [('tracking', '!=', 'serial')], 'required': [('create_fleet_vehicle', '=', True)]}"
+                        invisible="tracking != 'serial'"
+                        required="create_fleet_vehicle == True"
                     />
                 </group>
             </xpath>

fleet_vehicle_stock/views/product_template.xml

@@ -10,7 +10,8 @@
             <field name="tracking" position="after">
                 <field
                     name="create_fleet_vehicle"
-                    attrs="{'invisible': [('tracking', '!=', 'serial')]}"
+                    invisible="tracking != 'serial'"
+                    string="create fleet vehicle"
                 />
             </field>
             <xpath expr="//notebook" position="inside">
@@ -30,7 +31,8 @@
                 <group>
                     <field
                         name="fleet_vehicle_model_id"
-                        attrs="{'invisible': [('product_variant_count', '>', 1)], 'required': [('product_variant_count', '=', 1)]}"
+                        invisible="product_variant_count &gt; 1"
+                        required="product_variant_count == 1"
                     />
                 </group>
             </page>