[tx] Simplify LoRAMixin for linear and embedding case#983
Merged
pcmoritz merged 2 commits intoNovaSky-AI:mainfrom Jan 28, 2026
Merged
[tx] Simplify LoRAMixin for linear and embedding case#983pcmoritz merged 2 commits intoNovaSky-AI:mainfrom
pcmoritz merged 2 commits intoNovaSky-AI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the LoRAMixin to better separate the logic for linear and embedding layers. The introduction of the _compute_lora_intermediate method, which is overridden in LoRAEmbed, is a good use of polymorphism and simplifies the apply_lora method by removing conditional logic. My review includes a couple of minor suggestions to improve code clarity by marking unused function parameters, which is a good practice for maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We simplify the LoRAMixin by disentangling the linear and embedding case and handling them in LoRAMixin and LoRAEmbed respectively. This is in preparation for supporting LoRA for the flattened layout (tokens, *dims) in addition to (batch, seq_len, *dims) and also #969