Skip to content

Commit 7cad1fc

Browse files
committed
fix assembly signing
1 parent ccf12d9 commit 7cad1fc

3 files changed

Lines changed: 14 additions & 13 deletions

File tree

.github/workflows/build-test-publish.yml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ defaults:
1313
working-directory: src
1414

1515
jobs:
16-
build-and-test:
16+
build-test-publish:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- uses: actions/checkout@v4
@@ -24,21 +24,19 @@ jobs:
2424
8.0.x
2525
9.0.x
2626
27-
- name: Decrypt signing key
27+
- name: Decrypt signing key and delete public key
2828
run: |
2929
openssl aes-256-cbc -d -pbkdf2 \
3030
-in key_private.snk.enc \
3131
-out key_private.snk \
3232
-pass pass:${{ secrets.STRONG_NAME_PASSWORD }}
33+
rm -f key_public.snk
3334
3435
- name: Restore dependencies
3536
run: dotnet restore
3637

37-
- name: Build and sign (trusted release)
38-
run: dotnet build -c Release --no-restore \
39-
/p:SignAssembly=true \
40-
/p:PublicSign=false \
41-
/p:AssemblyOriginatorKeyFile=key_private.snk
38+
- name: Build
39+
run: dotnet build -c Release --no-restore
4240

4341
- name: Run Tests
4442
run: dotnet test -c Release --no-restore --no-build -v normal

src/Directory.Build.props

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,16 @@
77
<Copyright>Copyright (c) 2025 NotOfficer</Copyright>
88
</PropertyGroup>
99

10+
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' != 'true'">
11+
<SignAssembly>true</SignAssembly>
12+
<PublicSign>true</PublicSign>
13+
<AssemblyOriginatorKeyFile>..\key_public.snk</AssemblyOriginatorKeyFile>
14+
</PropertyGroup>
15+
1016
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
1117
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
18+
<SignAssembly>true</SignAssembly>
19+
<PublicSign>false</PublicSign>
20+
<AssemblyOriginatorKeyFile>..\key_private.snk</AssemblyOriginatorKeyFile>
1221
</PropertyGroup>
1322
</Project>

src/GenericReader/GenericReader.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
<Version>2.2.3</Version>
77
</PropertyGroup>
88

9-
<PropertyGroup>
10-
<SignAssembly>true</SignAssembly>
11-
<PublicSign>true</PublicSign>
12-
<AssemblyOriginatorKeyFile>..\key_public.snk</AssemblyOriginatorKeyFile>
13-
</PropertyGroup>
14-
159
<PropertyGroup>
1610
<GenerateDocumentationFile>false</GenerateDocumentationFile>
1711
<PackageIcon>icon.png</PackageIcon>

0 commit comments

Comments
 (0)