fixes

Author: dnakhooda

general/include/hdc2021debr.h

@@ -22,13 +22,13 @@ typedef enum {
 } HDC2021_REG_ADDR_t;
 
 /** Function Pointers */
-typedef int (*Write_ptr)(uint8_t *data, uint8_t dev_address, uint8_t length);
-typedef int (*Read_ptr)(uint8_t *data, uint8_t reg, uint8_t dev_address,
+typedef int (*Write_ptr_hdc)(uint8_t *data, uint8_t dev_address, uint8_t length);
+typedef int (*Read_ptr_hdc)(uint8_t *data, uint8_t reg, uint8_t dev_address,
 			uint8_t length);
 
 typedef struct {
-	Write_ptr write_reg;
-	Read_ptr read_reg;
+	Write_ptr_hdc write_reg;
+	Read_ptr_hdc read_reg;
 	float temp;
 	float humidity;
 	bool is_heater_enabled;
@@ -41,8 +41,9 @@ typedef struct {
  * @param hdc2021 - hdc2021debr driver
  * @return int - Status code
  */
-int hdc2021_init(hdc2021debr_t *hdc2021, Write_ptr write_reg, Read_ptr read_reg,
+int hdc2021_init(hdc2021debr_t *hdc2021, Write_ptr_hdc write_reg, Read_ptr_hdc read_reg,
 		   uint8_t dev_address);
+
 /**
  * @brief Toggles the status of the internal heater
  *
@@ -51,11 +52,21 @@ int hdc2021_init(hdc2021debr_t *hdc2021, Write_ptr write_reg, Read_ptr read_reg,
  * @return int - Status code
  */
 int hdc2021_toggle_heater(hdc2021debr_t *hdc2021, bool enable);
+
+/**
+ * @brief triggers oneshot measurement
+ *
+ * @param hdc2021 - hdc2021debr driver
+ * @return int - Status code
+ */
+int hdc2021_trigger_oneshot(hdc2021debr_t *hdc2021);
+
 /**
  * @brief Retrieves the temperature and humidity
  * @note Call hdc2021_trigger_oneshot() and wait a couple ms before calling this
  * @param hdc2021 - hdc2021debr driver
  * @return int - Status code
  */
 int hdc2021_get_temp_humid(hdc2021debr_t *hdc2021);
+
 #endif

general/src/hdc2021debr.c

@@ -14,7 +14,7 @@ static int hdc2021_read_reg(hdc2021debr_t *hdc2021, uint8_t reg, uint8_t *data,
     return hdc2021->read_reg(data, reg, hdc2021->dev_address, length);
 }
 
-int hdc2021_init(hdc2021debr_t *hdc2021, Write_ptr write_reg, Read_ptr read_reg,
+int hdc2021_init(hdc2021debr_t *hdc2021, Write_ptr_hdc write_reg, Read_ptr_hdc read_reg,
 		    uint8_t dev_address)
 {
 	hdc2021->write_reg = write_reg;
@@ -32,40 +32,40 @@ int hdc2021_toggle_heater(hdc2021debr_t *hdc2021, bool enable)
 			  sizeof(device_config))) 
 	{
 		return 1;
-	};
+	}
 
 	// the 3rd bit toggles the heater
-	if (enable) {
+	if (enable) 
+	{
 		device_config |= (1 << 3);
-	} else {
+	} else 
+	{
 		device_config &= ~(1 << 3);
-	};
+	}
 
 	if (hdc2021_write_reg(hdc2021, REG_DEVICE_CONFIG, device_config)) 
 	{
 		return 1;
-	};
+	}
 
-	return 0;
+	hdc2021->is_heater_enabled = enable;
 
+	return 0;
 }
-/**
- * @brief triggers oneshot measurement
- *
- * @param hdc2021 - hdc2021debr driver
- * @return int - Status code
- */
+
 int hdc2021_trigger_oneshot(hdc2021debr_t *hdc2021)
 {
     uint8_t config;
 
-    if (hdc2021_read_reg(hdc2021, REG_MEASURE_CONFIG, &config, 1)) {
+    if (hdc2021_read_reg(hdc2021, REG_MEASURE_CONFIG, &config, 1)) 
+	{
         return 1;
     }
 
     config |= 0x01;
 
-    if (hdc2021_write_reg(hdc2021, REG_MEASURE_CONFIG, config)) {
+    if (hdc2021_write_reg(hdc2021, REG_MEASURE_CONFIG, config)) 
+	{
         return 1;
     }
 
@@ -76,18 +76,13 @@ int hdc2021_get_temp_humid(hdc2021debr_t *hdc2021)
 {
 	uint8_t buffer[4];
 
-	if (hdc2021_trigger_oneshot(hdc2021)) {
-		return 1;
-	}
-
-
     if (hdc2021_read_reg(hdc2021, REG_TEMP_LOW, buffer, 4)) 
     {
         return 1;
-    };
+    }
 
-    uint16_t temp_bytes = (buffer[1] << 8) | buffer[0];
-    uint16_t humid_bytes = (buffer[3] << 8) | buffer[2];
+    uint16_t temp_bytes = ((uint16_t)(buffer[1]) << 8) | buffer[0];
+    uint16_t humid_bytes = ((uint16_t)(buffer[3]) << 8) | buffer[2];
 
     float tempVal = (((float)temp_bytes/65536.0f) * 165.0f) - 40.0f;
     hdc2021->temp = tempVal;