fix: stop the pack guard from blocking the release script

npm runs pre<name> for any script, so naming the release script "pack" made
prepack its own pre-hook - and prepack is the guard that refuses to pack the
repository root. npm run pack therefore always exited 1, which is exactly what
the release workflow calls.

Renamed to pack.release, matching build.release and clean.build. The guard
still fires for a real npm pack or npm publish at the root, which is what it
is for.

Author: edusperoni

.github/workflows/npm_release_cli.yml

@@ -105,7 +105,7 @@ jobs:
           echo IS_RELEASE=$IS_RELEASE >> $GITHUB_OUTPUT
 
       - name: Build nativescript
-        run: npm run pack
+        run: npm run pack.release
 
       - name: Upload npm package artifact
         uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0

package.json

@@ -31,7 +31,7 @@
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
     "prettier": "prettier --write ./lib/**/*{.ts,.d.ts} ./test/**/*{.ts,.d.ts}",
     "build.release": "npm run clean.build && tsc -p tsconfig.release.json && node scripts/generate-test-deps.js && node scripts/copy-assets.js --release && node scripts/set-ga-id.js live --dir dist && node scripts/set-ga-id.js verify --dir dist",
-    "pack": "npm run build.release && npm pack ./dist"
+    "pack.release": "npm run build.release && npm pack ./dist"
   },
   "repository": {
     "type": "git",

scripts/guard-root-pack.js

@@ -2,12 +2,15 @@
 // the repository root would produce a tarball with everything nested one level
 // deeper - every path the CLI resolves through __dirname would break, silently.
 // npm pack ./dist runs dist's own manifest, so this guard does not fire for it.
+//
+// The release script is deliberately not called "pack": npm runs pre<name> for
+// any script, so `npm run pack` would fire this guard as its own pre-hook.
 console.error(
   [
     "Refusing to pack the repository root.",
     "",
     "The published package is assembled in dist/. Use:",
-    "  npm run pack",
+    "  npm run pack.release",
     "",
     "which builds dist/ and runs `npm pack ./dist`.",
   ].join("\n")