test(doctor): run the suite with vitest, directly from TypeScript

Brings the package onto the same runner as the CLI. Unlike the CLI, nothing
here reflects over constructor source, so there is no reason to test the
compiled output - vitest runs the TypeScript directly. That removes the
dist-test build and the fixture copying that existed only to put example.zip
next to the compiled tests; resolved from the sources, it is already there.

tsconfig.test.json becomes a typecheck-only config, since test types were
previously checked as a side effect of compiling them.

The runner needed two changes: the extractZip test and its afterEach used
mocha's done callback, and android-tools-info used before/after.

82 passing, unchanged.

Author: edusperoni

packages/doctor/package.json

@@ -16,11 +16,11 @@
     "clean": "npx rimraf node_modules package-lock.json && npm i && npm run clean.build",
     "clean.build": "node scripts/clean.js",
     "build": "tsc",
-    "build.all": "tsc -p tsconfig.test.json && node scripts/copy-test-fixtures.js",
     "dev": "tsc --watch",
     "prepack": "npm run clean.build && npm test && tsc -p tsconfig.release.json",
-    "test": "npm run build.all && mocha --recursive dist-test/test",
-    "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s"
+    "test": "tsc -p tsconfig.test.json && vitest run",
+    "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
+    "test-watch": "vitest"
   },
   "repository": {
     "type": "git",
@@ -46,17 +46,16 @@
   "devDependencies": {
     "@types/chai": "5.2.2",
     "@types/lodash": "4.17.21",
-    "@types/mocha": "10.0.10",
     "@types/semver": "7.7.1",
     "@types/shelljs": "0.8.17",
     "@types/temp": "0.9.4",
     "@types/winreg": "1.2.36",
     "@types/yauzl": "2.10.3",
     "chai": "5.3.3",
     "conventional-changelog-cli": "^5.0.0",
-    "mocha": "11.7.5",
     "rimraf": "6.1.2",
-    "typescript": "~5.9.2"
+    "typescript": "~5.9.2",
+    "vitest": "^4.1.10"
   },
   "dependencies": {
     "lodash": "4.17.21",
@@ -65,4 +64,4 @@
     "winreg": "1.2.5",
     "yauzl": "3.2.0"
   }
-}
+}

packages/doctor/scripts/clean.js

@@ -19,7 +19,7 @@ if (result.status !== 0) {
 	throw new Error(`git clean exited with status ${result.status}`);
 }
 
-for (const dir of ["dist", "dist-test", "coverage"]) {
+for (const dir of ["dist", "coverage"]) {
 	fs.rmSync(path.join(rootDir, dir), { recursive: true, force: true });
 }
 

packages/doctor/scripts/copy-test-fixtures.js

@@ -23,7 +23,7 @@ describe("androidToolsInfo", () => {
 		EOL +
 		" described in " +
 		Constants.SYSTEM_REQUIREMENTS_LINKS;
-	before(() => {
+	beforeAll(() => {
 		process.env["ANDROID_HOME"] = "test";
 	});
 	const getAndroidToolsInfo = (runtimeVersion?: string): AndroidToolsInfo => {
@@ -404,7 +404,7 @@ describe("androidToolsInfo", () => {
 		});
 	});
 
-	after(() => {
+	afterAll(() => {
 		process.env["ANDROID_HOME"] = originalAndroidHome;
 	});
 });

packages/doctor/test/android-tools-info.ts

@@ -0,0 +1 @@
+/// <reference types="vitest/globals" />

packages/doctor/test/vitest-globals.d.ts

@@ -26,25 +26,20 @@ describe("FileSystem", () => {
 			`${tmpDir}/test/wrappers/file-system.ts`,
 		];
 
-		it("should extract in example zip archive in tmp folder", (done) => {
+		it("should extract in example zip archive in tmp folder", async () => {
 			const fs = new FileSystem();
 
-			fs.extractZip(testFilePath, tmpDir)
-				.then(() => {
-					const allExists = filesThatNeedToExist
-						.map(fs.exists)
-						.reduce((acc, r) => acc && r, true);
+			await fs.extractZip(testFilePath, tmpDir);
 
-					assert.isTrue(allExists);
+			const allExists = filesThatNeedToExist
+				.map(fs.exists)
+				.reduce((acc, r) => acc && r, true);
 
-					done();
-				})
-				.catch((e) => done(e));
+			assert.isTrue(allExists);
 		});
 
-		afterEach((done) => {
+		afterEach(() => {
 			rimrafSync(tmpDir);
-			done();
 		});
 	});
 });

packages/doctor/test/wrappers/file-system.ts

@@ -2,7 +2,7 @@
 	"extends": "./tsconfig.json",
 	"compilerOptions": {
 		"rootDir": ".",
-		"outDir": "dist-test",
+		"noEmit": true,
 		"declaration": false
 	},
 	"include": ["src/", "test/", "typings/"]

packages/doctor/tsconfig.test.json

@@ -0,0 +1,12 @@
+import { defineConfig } from "vitest/config";
+
+// Unlike the CLI, this package has no injector doing constructor-source
+// reflection, so the TypeScript sources run directly with no build step.
+export default defineConfig({
+	test: {
+		globals: true,
+		environment: "node",
+		include: ["test/**/*.ts"],
+		exclude: ["**/node_modules/**", "**/*.d.ts"],
+	},
+});