fix: initialize void pointers with nullptr

Author: ammarahm-ed

test-app/runtime/src/main/cpp/modules/url/URL.cpp

@@ -9,7 +9,7 @@ namespace {
     URL *GetInstance(napi_env env, napi_callback_info info) {
         NAPI_PREAMBLE
         napi_value jsThis;
-        void *data;
+        void *data = nullptr;
         NAPI_GUARD(napi_get_cb_info(env, info, nullptr, nullptr, &jsThis, &data)) {
             return nullptr;
         }

test-app/runtime/src/main/cpp/modules/url/URLPattern.cpp

@@ -49,7 +49,7 @@ namespace {
     URLPattern *GetInstance(napi_env env, napi_callback_info info) {
         size_t argc = 0;
         napi_value jsThis;
-        void *data;
+        void *data = nullptr;
         if (napi_get_cb_info(env, info, &argc, nullptr, &jsThis, &data) != napi_ok) {
             return nullptr;
         }

test-app/runtime/src/main/cpp/runtime/conversion/JsArgConverter.cpp

@@ -146,7 +146,7 @@ bool JsArgConverter::ConvertArg(napi_env env, napi_value arg, int index) {
                 CastType castType = CastType::None;
 
 #ifdef USE_HOST_OBJECT
-                void *data;
+                void *data = nullptr;
                 napi_get_host_object_data(env, arg, &data);
                 if (data) {
                     castType = CastType::None;
@@ -157,14 +157,17 @@ bool JsArgConverter::ConvertArg(napi_env env, napi_value arg, int index) {
                 castType = NumericCasts::GetCastType(m_env, arg);
 #endif
 
+                CastType castTypeCheck = NumericCasts::GetCastType(env, arg);
+                if (castTypeCheck != CastType::None) {
+                    castType = castTypeCheck;
+                }
                 napi_value castValue;
                 napi_valuetype valueType = napi_undefined;
                 if (castType != CastType::None) {
                     castValue = NumericCasts::GetCastValue(m_env, arg);
                     if (castValue != nullptr) {
                         napi_typeof(env, castValue, &valueType);
                     }
-
                 }
 
                 JniLocalRef obj;

test-app/runtime/src/main/cpp/runtime/conversion/JsArgToArrayConverter.cpp

@@ -113,7 +113,7 @@ bool JsArgToArrayConverter::ConvertArg(napi_env env, napi_value arg, int index)
 
         CastType castType = CastType::None;
 #ifdef USE_HOST_OBJECT
-        void *data;
+        void *data = nullptr;
         napi_get_host_object_data(env, jsObj, &data);
         if (data) {
             castType = CastType::None;
@@ -265,7 +265,7 @@ bool JsArgToArrayConverter::ConvertArg(napi_env env, napi_value arg, int index)
                     napi_value privateValue;
                     napi_get_named_property(env, jsObj, PROP_KEY_NULL_NODE_NAME, &privateValue);
                     if (!napi_util::is_null_or_undefined(env, privateValue)) {
-                        void *data;
+                        void *data = nullptr;
                         napi_get_value_external(env, privateValue, &data);
                         auto node = reinterpret_cast<MetadataNode *>(data);
                         if (node == nullptr) {

test-app/runtime/src/main/cpp/runtime/conversion/NumericCasts.h

@@ -24,17 +24,16 @@ namespace tns {
             CastType ret = CastType::None;
 
 #ifdef USE_HOST_OBJECT
-            void *data;
-            napi_get_host_object_data(env, object, &data);
-            if (data != nullptr) return ret;
+            bool is_host_object = false;
+            napi_is_host_object(env, object, &is_host_object);
+            if (is_host_object) return ret;
 #endif
 
             napi_value hidden;
-
-            bool hasProperty;
-            napi_has_named_property(env, object, s_castMarker, &hasProperty);
-
-            if (hasProperty) {
+            napi_get_named_property(env, object, s_castMarker, &hidden);
+            napi_valuetype type;
+            napi_typeof(env, hidden, &type);
+            if (type == napi_number) {
                 napi_get_named_property(env, object, s_castMarker, &hidden);
                 int32_t castType;
                 napi_get_value_int32(env, hidden, &castType);

test-app/runtime/src/main/cpp/runtime/messageloop/MessageLoopTimer.cpp

@@ -36,7 +36,7 @@ void MessageLoopTimer::RegisterStartStopFunctions(napi_env env) {
 
 napi_value MessageLoopTimer::StartCallback(napi_env env, napi_callback_info info) {
 
-    void * data;
+    void * data = nullptr;
     napi_get_cb_info(env, info, nullptr, nullptr, nullptr, &data);
 
     auto self = static_cast<MessageLoopTimer *>(data);
@@ -69,7 +69,7 @@ napi_value MessageLoopTimer::StartCallback(napi_env env, napi_callback_info info
 }
 
 napi_value MessageLoopTimer::StopCallback(napi_env env, napi_callback_info info) {
-    void * data;
+    void * data = nullptr;
     napi_get_cb_info(env, info, nullptr, nullptr, nullptr, &data);
     auto self = static_cast<MessageLoopTimer *>(data);
 

test-app/runtime/src/main/cpp/runtime/metadata/MetadataNode.h

@@ -39,7 +39,7 @@ class MetadataNode {
         // interceptor-forwarded "#instance_metadata" property get.
         return tns::Runtime::GetRuntime(env)->GetObjectManager()->GetInstanceNode(object);
 #else
-        void *node;
+        void *node = nullptr;
         napi_value external;
         napi_get_named_property(env, object, "#instance_metadata", &external);
 

test-app/runtime/src/main/cpp/runtime/metadata/MethodCache.h

@@ -155,7 +155,7 @@ class MethodCache {
 
             if (!napi_util::is_null_or_undefined(env, nullNode))
             {
-                void *data;
+                void *data = nullptr;
                 napi_get_value_external(env, nullNode, &data);
                 auto treeNode = reinterpret_cast<MetadataNode *>(data);
 

test-app/runtime/src/main/cpp/runtime/module/ModuleInternal.cpp

@@ -177,7 +177,7 @@ napi_value ModuleInternal::RequireCallbackImpl(napi_env env, napi_callback_info
 }
 
 napi_value ModuleInternal::RequireNativeCallback(napi_env env, napi_callback_info info) {
-    void* data;
+    void* data = nullptr;
     napi_get_cb_info(env, info, nullptr, nullptr, nullptr, &data);
     auto cb = reinterpret_cast<napi_register_module_v *>(data);
     napi_value exports;

test-app/runtime/src/main/cpp/runtime/objectmanager/ObjectManager.cpp

@@ -618,7 +618,7 @@ ObjectManager::GetJSInstanceInfoFromRuntimeObject(napi_value object) {
     }
 
     if (!napi_util::is_null_or_undefined(m_env, jsInfo)) {
-        void *data;
+        void *data = nullptr;
         napi_get_value_external(m_env, jsInfo, &data);
         auto info = reinterpret_cast<JSInstanceInfo *>(data);
         return info;
@@ -898,7 +898,7 @@ void ObjectManager::ReleaseNativeObject(napi_env env, napi_value object) {
     JSInstanceInfo *jsInstanceInfo;
 
 #ifdef USE_HOST_OBJECT
-    void* data;
+    void* data = nullptr;
     napi_get_host_object_data(env, object, &data);
     if (data) {
         jsInstanceInfo = reinterpret_cast<HostObjectProxy *>(data)->instanceInfo;