Skip to content

faild to build with ESP IDF #1925

@BartolomeyKant

Description

@BartolomeyKant

the error is:

/home/bartolomey/projects/aether-client-cpp/third_party/stdexec/include/stdexec/__detail/__stop_when.hpp:107:27: error: expected identifier before numeric constant
  107 |           template <class _C>
      |                           ^~
/home/bartolomey/projects/aether-client-cpp/third_party/stdexec/include/stdexec/__detail/__stop_when.hpp:107:27: error: expected '>' before numeric constant
In file included from /home/bartolomey/projects/aether-client-cpp/third_party/stdexec/include/stdexec/__detail/__counting_scopes.hpp:28,
                 from /home/bartolomey/projects/aether-client-cpp/third_party/stdexec/include/stdexec/execution.hpp:29,
                 from /home/bartolomey/projects/aether-client-cpp/aether/executors/executors.h:22,
                 from /home/bartolomey/projects/aether-client-cpp/aether/all.h:27,
                 from /home/bartolomey/projects/aether-client-cpp/examples/cloud/cloud_test.cpp:20:
/home/bartolomey/projects/aether-client-cpp/third_party/stdexec/include/stdexec/__detail/__stop_when.hpp:108:29: error: type/value mismatch at argument 2 in template parameter list for 'template<class _Ty, class ... _As> concept stdexec::__std::constructible_from'
  108 |             requires __std::constructible_from<_Fn, _C>
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~

... and so on.

The problem is that _C is defined as macro in ctype.h on that platform.

I found the same issue kokkos/mdspan#187

Also clang-tidy complains on that code with https://clang.llvm.org/extra/clang-tidy/checks/bugprone/reserved-identifier.html. I not sure if that applicable for stdexec as it's reference for standard implementation, but why use _FN _C instead of just FN and C?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions