fix(ci): improve CI infrastructure reliability

- Add timeout-minutes to all workflow jobs

- Add set -euo pipefail and quote variables in install-operator.sh

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Author: ArangoGutierrez

.github/workflows/config-checks.yaml

@@ -21,6 +21,7 @@ on:
 jobs:
   helm-lint:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -31,6 +32,7 @@ jobs:
 
   validate-csv:
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
       - name: Checkout code
         uses: actions/checkout@v6
@@ -47,6 +49,7 @@ jobs:
 
   validate-helm-values:
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
       - name: Checkout code
         uses: actions/checkout@v6

.github/workflows/e2e-tests.yaml

@@ -65,6 +65,7 @@ jobs:
   e2e-tests-containerd:
     needs: [variables]
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 90
     permissions:
       contents: read
       id-token: write
@@ -130,6 +131,7 @@ jobs:
   e2e-tests-nvidiadriver:
     needs: [variables]
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 90
     permissions:
       contents: read
       id-token: write

.github/workflows/forward-compatibility.yaml

@@ -28,6 +28,7 @@ permissions: {}
 jobs:
   fetch-latest-images:
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     permissions:
       contents: read
     steps:
@@ -77,11 +78,15 @@ jobs:
 
   notify-failure:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     permissions: {}
     needs: [fetch-latest-images, run-e2e-tests]
-    if: ${{ always() && (needs.fetch-latest-images.result == 'failure' || needs.run-e2e-tests.result == 'failure') && secrets.SLACK_BOT_TOKEN != '' }}
+    if: ${{ always() && (needs.fetch-latest-images.result == 'failure' || needs.run-e2e-tests.result == 'failure') }}
+    env:
+      SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
     steps:
       - name: Send Slack alert notification
+        if: ${{ env.SLACK_BOT_TOKEN != '' }}
         uses: slackapi/slack-github-action@v2.1.1
         with:
           method: chat.postMessage

.github/workflows/golang-checks.yaml

@@ -21,6 +21,7 @@ on:
 jobs:
   go-check:
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 30
     permissions:
       contents: read
       id-token: write
@@ -55,6 +56,7 @@ jobs:
   go-test:
     name: unit tests
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 30
     permissions:
       contents: read
       id-token: write
@@ -80,6 +82,7 @@ jobs:
 
   go-build:
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 30
     permissions:
       contents: read
       id-token: write

.github/workflows/image-builds.yaml

@@ -33,6 +33,7 @@ on:
 jobs:
   variables:
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     outputs:
       commit_short_sha: ${{ steps.vars.outputs.commit_short_sha }}
       label_image_source: ${{ steps.vars.outputs.label_image_source }}
@@ -77,6 +78,7 @@ jobs:
   build-gpu-operator-arm64:
     needs: [variables]
     runs-on: linux-arm64-cpu4
+    timeout-minutes: 45
     permissions:
       contents: read
       id-token: write
@@ -108,6 +110,7 @@ jobs:
   build-gpu-operator-amd64:
     needs: [variables]
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 45
     permissions:
       contents: read
       id-token: write
@@ -139,6 +142,7 @@ jobs:
   build-multi-arch-images:
     needs: [variables, build-gpu-operator-arm64, build-gpu-operator-amd64]
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
       - uses: actions/checkout@v6
         name: Check out code

.github/workflows/release.yaml

@@ -29,6 +29,7 @@ permissions: {}
 jobs:
   variables:
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     outputs:
       commit_short_sha: ${{ steps.vars.outputs.commit_short_sha }}
       operator_image_base: ${{ steps.vars.outputs.operator_image_base }}
@@ -60,6 +61,7 @@ jobs:
   release-latest-gpu-operator-image:
     needs: [variables]
     runs-on: linux-amd64-cpu4
+    timeout-minutes: 30
     permissions:
       contents: read
       packages: write

tests/scripts/install-operator.sh

@@ -1,14 +1,15 @@
 #!/bin/bash
+set -euo pipefail
 
 if [[ "${SKIP_INSTALL}" == "true" ]]; then
     echo "Skipping install: SKIP_INSTALL=${SKIP_INSTALL}"
     exit 0
 fi
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source ${SCRIPT_DIR}/.definitions.sh
+source "${SCRIPT_DIR}/.definitions.sh"
 
-OPERATOR_REPOSITORY=$(dirname ${OPERATOR_IMAGE})
+OPERATOR_REPOSITORY=$(dirname "${OPERATOR_IMAGE}")
 
 # Determine if we should use values file approach or --set flags
 USE_VALUES_FILE=false