Skip to content

fix(scripts): replace mapfile with bash 3.2-compatible read loop in helm-k3s-local #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesutoezdil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scripts): replace mapfile with bash 3.2-compatible read loop in helm-k3s-local #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tasks/scripts/helm-k3s-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ configure_ghcr_credentials() {
registries_content="$(printf 'configs:\n "ghcr.io":\n auth:\n username: %s\n password: %s\n' \
"${GITHUB_USERNAME}" "${GITHUB_PAT}")"

local -a nodes
mapfile -t nodes < <(docker ps --format '{{.Names}}' \
local -a nodes=()
while IFS= read -r _node; do nodes+=("$_node"); done < <(docker ps --format '{{.Names}}' \
--filter "name=k3d-${CLUSTER_NAME}-server-" 2>/dev/null || true)

if [[ ${#nodes[@]} -eq 0 ]]; then
Expand All @@ -168,8 +168,8 @@ configure_ghcr_credentials() {

cluster_has_image() {
local image="$1"
local -a nodes
mapfile -t nodes < <(docker ps --format '{{.Names}}' \
local -a nodes=()
while IFS= read -r _node; do nodes+=("$_node"); done < <(docker ps --format '{{.Names}}' \
--filter "name=k3d-${CLUSTER_NAME}-server-" 2>/dev/null || true)

for node in "${nodes[@]}"; do
Expand All @@ -182,8 +182,8 @@ cluster_has_image() {
}

cluster_image_platform() {
local -a nodes
mapfile -t nodes < <(docker ps --format '{{.Names}}' \
local -a nodes=()
while IFS= read -r _node; do nodes+=("$_node"); done < <(docker ps --format '{{.Names}}' \
--filter "name=k3d-${CLUSTER_NAME}-server-" 2>/dev/null || true)

if [[ ${#nodes[@]} -gt 0 ]]; then
Expand Down
Loading