Some could argue that this is rather an enhancement.
Also I'm surprised that a (shallow) web search on this matter didn't reveal very much.
@Describe the bug
A header file should be self contained, that is for every thing that it uses it should have the appropriate #include. That way, any other file including it won't have to include its dependencies (do the included file's job).
I've noticed this in several DeepStream files. Since I'm working on Videotemplate, exemplifying:
Steps/Code to reproduce bug
Check CristiFati/pycfgst - testlib0.cpp (at the beginning) the #includes marked with TODO. Commenting out any of them, the build would yield a compile error.
Expected behavior
Client source files should not be forced to have includes (that they don't directly use stuff from) for code to compile.
Environment details (please complete the following information):
N/A, tried on a DS container (Ubuntu)
Additional context
Add any other context about the problem here.
By submitting this issue, you agree to follow our code of conduct and our contribution guidelines.
Some could argue that this is rather an enhancement.
Also I'm surprised that a (shallow) web search on this matter didn't reveal very much.
@Describe the bug
A header file should be self contained, that is for every thing that it uses it should have the appropriate
#include. That way, any other file including it won't have to include its dependencies (do the included file's job).I've noticed this in several DeepStream files. Since I'm working on Videotemplate, exemplifying:
NvBufSurfacebut doesn't have#include <nvbufsurface.h>Steps/Code to reproduce bug
Check CristiFati/pycfgst - testlib0.cpp (at the beginning) the
#includesmarked with TODO. Commenting out any of them, the build would yield a compile error.Expected behavior
Client source files should not be forced to have includes (that they don't directly use stuff from) for code to compile.
Environment details (please complete the following information):
N/A, tried on a DS container (Ubuntu)
Additional context
Add any other context about the problem here.
By submitting this issue, you agree to follow our code of conduct and our contribution guidelines.