From 1998f08c1a28e6d5cca6857f2686b7dd5d5adc2d Mon Sep 17 00:00:00 2001 From: damientobin1 Date: Thu, 14 May 2026 13:57:17 +0100 Subject: [PATCH 1/2] CCM-18036: Clean-Up Of Move To Shared Modules Model --- .github/workflows/cicd-4-pr-title-check.yaml | 2 +- .../scheduled-repository-template-sync.yaml | 2 +- .github/workflows/stage-1-commit.yaml | 16 ++++++++-------- .github/workflows/stage-2-test.yaml | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/cicd-4-pr-title-check.yaml b/.github/workflows/cicd-4-pr-title-check.yaml index 5b42a8f16..c59335838 100644 --- a/.github/workflows/cicd-4-pr-title-check.yaml +++ b/.github/workflows/cicd-4-pr-title-check.yaml @@ -15,6 +15,6 @@ jobs: runs-on: ubuntu-latest steps: - name: "Check PR title format" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-pr-title-format@4e781d1d72739015821a380871aa5a66d070177c # 3.1.0 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-pr-title-format@4.0.0 # 3.1.0 with: title: ${{ github.event.pull_request.title }} diff --git a/.github/workflows/scheduled-repository-template-sync.yaml b/.github/workflows/scheduled-repository-template-sync.yaml index e86287866..5557f55b1 100644 --- a/.github/workflows/scheduled-repository-template-sync.yaml +++ b/.github/workflows/scheduled-repository-template-sync.yaml @@ -18,7 +18,7 @@ jobs: - name: Check out the repository uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 - name: Sync repository template - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/sync-template-repo@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/sync-template-repo@4.0.0 with: github_token: ${{ github.token }} diff --git a/.github/workflows/stage-1-commit.yaml b/.github/workflows/stage-1-commit.yaml index f5af737ee..2b0d75c6c 100644 --- a/.github/workflows/stage-1-commit.yaml +++ b/.github/workflows/stage-1-commit.yaml @@ -51,7 +51,7 @@ jobs: with: fetch-depth: 0 # Full history is needed to scan all commits - name: "Scan secrets" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/scan-secrets@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/scan-secrets@4.0.0 check-file-format: name: "Check file format" runs-on: ubuntu-latest @@ -62,7 +62,7 @@ jobs: with: fetch-depth: 0 # Full history is needed to compare branches - name: "Check file format" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-file-format@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-file-format@4.0.0 check-markdown-format: name: "Check Markdown format" runs-on: ubuntu-latest @@ -73,7 +73,7 @@ jobs: with: fetch-depth: 0 # Full history is needed to compare branches - name: "Check Markdown format" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-markdown-format@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-markdown-format@4.0.0 terraform-docs: name: "Run terraform-docs" runs-on: ubuntu-latest @@ -108,7 +108,7 @@ jobs: with: fetch-depth: 0 # Full history is needed to compare branches - name: "Check English usage" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-english-usage@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-english-usage@4.0.0 check-todo-usage: name: "Check TODO usage" runs-on: ubuntu-latest @@ -119,7 +119,7 @@ jobs: with: fetch-depth: 0 # Full history is needed to compare branches - name: "Check TODO usage" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-todo-usage@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-todo-usage@4.0.0 detect-terraform-changes: name: "Detect Terraform Changes" runs-on: ubuntu-latest @@ -154,7 +154,7 @@ jobs: - name: "Setup ASDF" uses: asdf-vm/actions/setup@1902764435ca0dd2f3388eea723a4f92a4eb8302 - name: "Lint Terraform" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/lint-terraform@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/lint-terraform@4.0.0 # TODO - Re-visit Trivy usage https://nhsd-jira.digital.nhs.uk/browse/CCM-15549 # trivy-iac: # name: "Trivy IaC Scan" @@ -200,7 +200,7 @@ jobs: - name: "Checkout code" uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 - name: "Count lines of code" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/create-lines-of-code-report@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/create-lines-of-code-report@4.0.0 with: build_datetime: "${{ inputs.build_datetime }}" build_timestamp: "${{ inputs.build_timestamp }}" @@ -219,7 +219,7 @@ jobs: - name: "Checkout code" uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 - name: "Scan dependencies" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/scan-dependencies@3.0.8 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/scan-dependencies@4.0.0 with: build_datetime: "${{ inputs.build_datetime }}" build_timestamp: "${{ inputs.build_timestamp }}" diff --git a/.github/workflows/stage-2-test.yaml b/.github/workflows/stage-2-test.yaml index b4244d315..34880e532 100644 --- a/.github/workflows/stage-2-test.yaml +++ b/.github/workflows/stage-2-test.yaml @@ -245,7 +245,7 @@ jobs: with: name: code-coverage-report - name: "Perform static analysis" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/perform-static-analysis@3.1.2 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/perform-static-analysis@4.0.0 with: sonar_organisation_key: "${{ vars.SONAR_ORGANISATION_KEY }}" sonar_project_key: "${{ vars.SONAR_PROJECT_KEY }}" From 0393c550a3a9f5c9e810b1264170aad4e9b42514 Mon Sep 17 00:00:00 2001 From: damientobin1 Date: Fri, 15 May 2026 10:19:00 +0100 Subject: [PATCH 2/2] CCM-18036: Clean-Up Of Move To Shared Modules Model --- .github/workflows/cicd-4-pr-title-check.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cicd-4-pr-title-check.yaml b/.github/workflows/cicd-4-pr-title-check.yaml index c59335838..a5c938df5 100644 --- a/.github/workflows/cicd-4-pr-title-check.yaml +++ b/.github/workflows/cicd-4-pr-title-check.yaml @@ -15,6 +15,6 @@ jobs: runs-on: ubuntu-latest steps: - name: "Check PR title format" - uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-pr-title-format@4.0.0 # 3.1.0 + uses: NHSDigital/nhs-notify-shared-modules/.github/actions/check-pr-title-format@4.0.0 with: title: ${{ github.event.pull_request.title }}