fix: damage reputation loss is now proportional rather than constant

Author: BenjaminAmos

engine/src/main/java/org/destinationsol/game/FactionManager.java

@@ -69,13 +69,13 @@ public FactionManager(FactionsConfigs factionsConfigs) {
      * @param event the event that occurred.
      * @param <T> the type of event.
      */
-    public <T extends Enum<T> & ReputationEvent> void reportEvent(Faction instigator, Faction target, T event) {
+    public <T extends ReputationEvent> void reportEvent(Faction instigator, Faction target, T event) {
         // TODO: Add support for custom event handlers.
         //       Some examples:
         //       - A pacifist faction is offended by any attacks made by a faction, regardless of the target.
         //       - A merchant faction may randomly give a free bonus when buying items.
         //       - A protective faction may dispatch a fleet to intercept the attacker if one of their ships is attacked.
-        Integer targetReputationImpact = target.getReputationImpact(event);
+        Float targetReputationImpact = target.getReputationImpact(event);
         if (targetReputationImpact != null) {
             target.setRelation(instigator, target.getRelation(instigator) + targetReputationImpact);
         } else {

engine/src/main/java/org/destinationsol/game/Rubble.java

@@ -101,7 +101,7 @@ public void onRemove(SolGame game) {
     }
 
     @Override
-    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
     }
 
     @Override

engine/src/main/java/org/destinationsol/game/SolObject.java

@@ -80,12 +80,13 @@ public interface SolObject {
      * no health pool or should be otherwise indestructible, or invincible against some types of damage, this method can
      * be freely left blank.
      *
-     * @param dmg      Damage the object receives.
-     * @param game     Game this object belongs to.
-     * @param position Position the object was hit at, if hit by point-based damage. Null if not applicable, such as fire.
-     * @param dmgType  Type of the damage object receives.
+     * @param dmg        Damage the object receives.
+     * @param game       Game this object belongs to.
+     * @param position   Position the object was hit at, if hit by point-based damage. Null if not applicable, such as fire.
+     * @param dmgType    Type of the damage object receives.
+     * @param instigator Object that damaged this object.
      */
-    void receiveDmg(float dmg, SolGame game, @Nullable Vector2 position, DmgType dmgType);
+    void receiveDmg(float dmg, SolGame game, @Nullable Vector2 position, DmgType dmgType, @Nullable SolObject instigator);
 
     /**
      * Denotes whether this object is affected by gravity.

engine/src/main/java/org/destinationsol/game/SolObjectEntityWrapper.java

@@ -62,7 +62,7 @@ public void onRemove(SolGame game) {
     }
 
     @Override
-    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
 
     }
 

engine/src/main/java/org/destinationsol/game/StarPort.java

@@ -156,8 +156,9 @@ public void onRemove(SolGame game) {
     }
 
     @Override
-    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
         game.getContext().get(SpecialSounds.class).playHit(game, this, position, dmgType);
+        // TODO: Reduce reputation with the origin planet's owning faction when planet ownership is implemented.
     }
 
     @Override
@@ -436,7 +437,7 @@ public void onRemove(SolGame game) {
         }
 
         @Override
-        public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+        public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
             game.getContext().get(SpecialSounds.class).playHit(game, this, position, dmgType);
         }
 

engine/src/main/java/org/destinationsol/game/asteroid/Asteroid.java

@@ -112,7 +112,7 @@ public void handleContact(SolObject other, float absImpulse, SolGame game, Vecto
         } else {
             dmg = absImpulse / mass / DUR;
         }
-        receiveDmg(dmg, game, collPos, DmgType.CRASH);
+        receiveDmg(dmg, game, collPos, DmgType.CRASH, null);
     }
 
     @Override
@@ -149,7 +149,7 @@ private boolean updateInAtm(SolGame game) {
         }
 
         float dmg = body.getLinearVelocity().len() * SPD_TO_ATM_DMG * game.getTimeStep();
-        receiveDmg(dmg, game, null, DmgType.FIRE);
+        receiveDmg(dmg, game, null, DmgType.FIRE, null);
         return true;
     }
 
@@ -215,7 +215,7 @@ private void throwLoot(SolGame game, SolItem item) {
     }
 
     @Override
-    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
         life -= dmg;
         game.getContext().get(SpecialSounds.class).playHit(game, this, position, dmgType);
     }

engine/src/main/java/org/destinationsol/game/console/commands/DieCommandHandler.java

@@ -38,7 +38,7 @@ public String die(@Game SolGame game) throws CommandExecutionException {
         if (!hero.isAlive()) {
             throw new CommandExecutionException("Hero is already dead!");
         }
-        hero.getShip().receivePiercingDmg(hero.getHull().getHullConfig().getMaxLife() + 1f, game, hero.getPosition(), DmgType.CRASH);
+        hero.getShip().receivePiercingDmg(hero.getHull().getHullConfig().getMaxLife() + 1f, game, hero.getPosition(), DmgType.CRASH, null);
         return "Hero killed!";
     }
 }

engine/src/main/java/org/destinationsol/game/drawables/DrawableObject.java

@@ -116,7 +116,7 @@ public void onRemove(SolGame game) {
     }
 
     @Override
-    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType) {
+    public void receiveDmg(float dmg, SolGame game, Vector2 position, DmgType dmgType, SolObject instigator) {
     }
 
     @Override

engine/src/main/java/org/destinationsol/game/faction/DamageInflictedReputationEvent.java

@@ -0,0 +1,47 @@
+/*
+ * Copyright 2026 The Terasology Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.destinationsol.game.faction;
+
+/**
+ * A reputation-affecting event raised when a ship (or projectile fired by a ship) causes damage to another.
+ */
+public class DamageInflictedReputationEvent implements ReputationEvent {
+    // This constant is calculated based on backwards compatibility with the old "1 hit = -1 reputation" logic,
+    // assuming a normal bullet clip that deals 1.6 units of damage (same as the Heavy Machine Gun at the time).
+    public static final float DAMAGE_REPUTATION_MODIFIER = 1.0f / 1.6f;
+    private final float damageTaken;
+
+    public DamageInflictedReputationEvent(float damageTaken) {
+        this.damageTaken = damageTaken;
+    }
+
+    /**
+     * Returns the quantity of damage caused by the instigator.
+     * @return the quantity of damage caused by the instigator.
+     */
+    public float getDamageTaken() {
+        return damageTaken;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    @Override
+    public float getDefaultReputationImpact() {
+        return -(damageTaken * DAMAGE_REPUTATION_MODIFIER);
+    }
+}

engine/src/main/java/org/destinationsol/game/faction/DefaultReputationEvent.java

@@ -48,7 +48,7 @@ public enum DefaultReputationEvent implements ReputationEvent {
      * @return the default impact on reputation this event will have in absence of a faction-specific value.
      */
     @Override
-    public int getDefaultReputationImpact() {
+    public float getDefaultReputationImpact() {
         return defaultReputationImpact;
     }
 }